Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Graph fixes + other stuff #434

Open
wants to merge 35 commits into
base: main
Choose a base branch
from
Open

Graph fixes + other stuff #434

wants to merge 35 commits into from

Commits on May 12, 2023

  1. Update OpenCL headers in include/CL 

    this is required for cl_khr_command_buffer
    @franz
    franz committed May 12, 2023
    Configuration menu
    Copy the full SHA
    450c3e6 View commit details
    Browse the repository at this point in the history

  2. opencl.hpp: make clGetDeviceInfo recognize Intel Subgroup Size

    @franz
    franz committed May 12, 2023
    Configuration menu
    Copy the full SHA
    8714c1e View commit details
    Browse the repository at this point in the history

  3. add include/CL/cl_ext_pocl.h (required for command buffer extensions)

    @franz
    franz committed May 12, 2023
    Configuration menu
    Copy the full SHA
    d34db90 View commit details
    Browse the repository at this point in the history

  4. src/CHIPBindings.cc: add missing error-checking for Graph API

    @franz
    franz committed May 12, 2023
    Configuration menu
    Copy the full SHA
    525f0a4 View commit details
    Browse the repository at this point in the history

  5. implement CHIPGraphNative 

    This class is used to implement Graphs that execute "natively"
in the backend, using OpenCL command-buffers or LevelZero command-lists
and only synchronizing with the host when required. Fallback to
original Graph is provided in CHIPGraphExec::launch()
    @franz
    franz committed May 12, 2023
    Configuration menu
    Copy the full SHA
    c4f654e View commit details
    Browse the repository at this point in the history

  6. cleanup/refactor OpenCL backend code 

    * turn CHIPEvent.Refc from pointer to integer,
  move it into CHIPEventLevel0
* disable increaseRefCount/decreaseRefCount for OpenCL,
  the OpenCL runtime already does the refcounting
* remove naked pointers to OpenCL objects, instead
  use the smart pointers from opencl.hpp header
    @franz
    franz committed May 12, 2023
    Configuration menu
    Copy the full SHA
    c36b530 View commit details
    Browse the repository at this point in the history

  7. add more error-checking & bugfixes 

    "ctest --timeout 120 -R Unit_hipGraph" with POCL (with
the new cl_pocl_command_buffer_* extensions) reports

59% tests passed, 62 tests failed out of 152

additionally, samples/graph + samples/graphMatrixMultiply
work using the "native graphs" (cl_command_buffer), not
the original chip-spv's graph execution.
    @franz
    franz committed May 12, 2023
    Configuration menu
    Copy the full SHA
    4aeedfa View commit details
    Browse the repository at this point in the history

  8. OpenCL backend: add support for cl_intel_unified_shared_memory 

    Previously, the OpenCL device was checked for fine-grained SVM support,
and if it was unavailable, the backend would assume only coarse-grained
support and insert SVMMap & SVMUnmap for each buffer used by a kernel.

Since Intel OpenCL and PoCL both support the USM extension now, but
don't support fine-grained SVM, this commit helps to avoid the overhead
of the unnecessary Map & Unmap commands.
    @franz
    franz committed May 12, 2023
    Configuration menu
    Copy the full SHA
    689cd1f View commit details
    Browse the repository at this point in the history

  9. src/CHIPBindings_spt.cc: add missing return from function

    @franz
    franz committed May 12, 2023
    Configuration menu
    Copy the full SHA
    377f98d View commit details
    Browse the repository at this point in the history

  10. samples/hip-cuda: disable printfs on each kernel iteration

    @franz
    franz committed May 12, 2023
    Configuration menu
    Copy the full SHA
    09df3c8 View commit details
    Browse the repository at this point in the history

  11. samples/hip-cuda: convert tests to report also Best iteration time 

    original code reports Average iteration time
    @franz
    franz committed May 12, 2023
    Configuration menu
    Copy the full SHA
    b7c0212 View commit details
    Browse the repository at this point in the history

  12. update unit tests with failing/passing Graph tests

    @franz
    franz committed May 12, 2023
    Configuration menu
    Copy the full SHA
    a6e2750 View commit details
    Browse the repository at this point in the history

Commits on May 14, 2023

  1. update test_lists again, move graphs to FAILING_FOR_ALL

    @franz
    franz committed May 14, 2023
    Configuration menu
    Copy the full SHA
    10b2fa1 View commit details
    Browse the repository at this point in the history

  2. fix a problem with UserEvents released too early

    @franz
    franz committed May 14, 2023
    Configuration menu
    Copy the full SHA
    781d7a9 View commit details
    Browse the repository at this point in the history

  3. disable USM memory allocation types other than Shared 

    enabling Device/Host USM types make some Texture tests fail
    @franz
    franz committed May 14, 2023
    Configuration menu
    Copy the full SHA
    7264667 View commit details
    Browse the repository at this point in the history

  4. disable USM support by default, can be enabled with CMake option

    @franz
    franz committed May 14, 2023
    Configuration menu
    Copy the full SHA
    f298848 View commit details
    Browse the repository at this point in the history

Commits on May 17, 2023

  1. Update src/CHIPBackend.cc 

    Co-authored-by: Henry Linjamäki <linehill@users.noreply.github.com>
    @franz @linehill
    franz and linehill authored May 17, 2023
    Configuration menu
    Copy the full SHA
    a9f09e7 View commit details
    Browse the repository at this point in the history

  2. Update src/CHIPBindings.cc 

    Co-authored-by: Henry Linjamäki <linehill@users.noreply.github.com>
    @franz @linehill
    franz and linehill authored May 17, 2023
    Configuration menu
    Copy the full SHA
    7ee740f View commit details
    Browse the repository at this point in the history

  3. Style fix src/CHIPGraph.cc 

    Co-authored-by: Henry Linjamäki <linehill@users.noreply.github.com>
    @franz @linehill
    franz and linehill authored May 17, 2023
    Configuration menu
    Copy the full SHA
    79edc52 View commit details
    Browse the repository at this point in the history

  4. Style fix src/backend/OpenCL/CHIPBackendOpenCL.cc 

    Co-authored-by: Henry Linjamäki <linehill@users.noreply.github.com>
    @franz @linehill
    franz and linehill authored May 17, 2023
    Configuration menu
    Copy the full SHA
    b840157 View commit details
    Browse the repository at this point in the history

  5. Style fix src/CHIPGraph.cc 

    Co-authored-by: Henry Linjamäki <linehill@users.noreply.github.com>
    @franz @linehill
    franz and linehill authored May 17, 2023
    Configuration menu
    Copy the full SHA
    ba74330 View commit details
    Browse the repository at this point in the history

  6. Style fix src/backend/OpenCL/CHIPBackendOpenCL.cc 

    Co-authored-by: Henry Linjamäki <linehill@users.noreply.github.com>
    @franz @linehill
    franz and linehill authored May 17, 2023
    Configuration menu
    Copy the full SHA
    0aec729 View commit details
    Browse the repository at this point in the history

  7. Style fix src/backend/OpenCL/CHIPBackendOpenCL.cc 

    Co-authored-by: Henry Linjamäki <linehill@users.noreply.github.com>
    @franz @linehill
    franz and linehill authored May 17, 2023
    Configuration menu
    Copy the full SHA
    e806f19 View commit details
    Browse the repository at this point in the history

  8. Style fix src/backend/OpenCL/SVMemoryRegion.cc 

    Co-authored-by: Henry Linjamäki <linehill@users.noreply.github.com>
    @franz @linehill
    franz and linehill authored May 17, 2023
    Configuration menu
    Copy the full SHA
    2f9f86e View commit details
    Browse the repository at this point in the history

  9. Avoid unnecessary copy in Kernel->getName() 

    Co-authored-by: Henry Linjamäki <linehill@users.noreply.github.com>
    @franz @linehill
    franz and linehill authored May 17, 2023
    Configuration menu
    Copy the full SHA
    e6aa207 View commit details
    Browse the repository at this point in the history

  10. add const to bool methods 

    Co-authored-by: Henry Linjamäki <linehill@users.noreply.github.com>
    @franz @linehill
    franz and linehill authored May 17, 2023
    Configuration menu
    Copy the full SHA
    fb5d7e2 View commit details
    Browse the repository at this point in the history

  11. Style fix src/backend/OpenCL/CHIPBackendOpenCL.cc 

    Co-authored-by: Henry Linjamäki <linehill@users.noreply.github.com>
    @franz @linehill
    franz and linehill authored May 17, 2023
    Configuration menu
    Copy the full SHA
    29651da View commit details
    Browse the repository at this point in the history

  12. Style fix src/backend/OpenCL/CHIPBackendOpenCL.cc 

    Co-authored-by: Henry Linjamäki <linehill@users.noreply.github.com>
    @franz @linehill
    franz and linehill authored May 17, 2023
    Configuration menu
    Copy the full SHA
    282a90c View commit details
    Browse the repository at this point in the history

  13. Style fix src/CHIPGraph.cc 

    Co-authored-by: Henry Linjamäki <linehill@users.noreply.github.com>
    @franz @linehill
    franz and linehill authored May 17, 2023
    Configuration menu
    Copy the full SHA
    1e1fafc View commit details
    Browse the repository at this point in the history

  14. Style fix src/CHIPBindings.cc 

    Co-authored-by: Henry Linjamäki <linehill@users.noreply.github.com>
    @franz @linehill
    franz and linehill authored May 17, 2023
    Configuration menu
    Copy the full SHA
    84ab96d View commit details
    Browse the repository at this point in the history

  15. Style fix src/CHIPGraph.cc 

    Co-authored-by: Henry Linjamäki <linehill@users.noreply.github.com>
    @franz @linehill
    franz and linehill authored May 17, 2023
    Configuration menu
    Copy the full SHA
    d922f75 View commit details
    Browse the repository at this point in the history

  16. Style fixes

    @franz
    franz committed May 17, 2023
    Configuration menu
    Copy the full SHA
    79a6e38 View commit details
    Browse the repository at this point in the history

  17. More fixes, remove unused code / comments

    @franz
    franz committed May 17, 2023
    Configuration menu
    Copy the full SHA
    d7a0e71 View commit details
    Browse the repository at this point in the history

  18. Rename getRegion -> getSVMRegion, rename private variables

    @franz
    franz committed May 17, 2023
    Configuration menu
    Copy the full SHA
    582d4ff View commit details
    Browse the repository at this point in the history

  19. Style fix src/CHIPGraph.hh 

    Co-authored-by: Henry Linjamäki <linehill@users.noreply.github.com>
    @franz @linehill
    franz and linehill authored May 17, 2023
    Configuration menu
    Copy the full SHA
    0f4f3c8 View commit details
    Browse the repository at this point in the history