Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement missing host-side math functions #884

Merged
merged 4 commits into from
Jul 24, 2024
Merged

Conversation

pvelesko
Copy link
Collaborator

@pvelesko pvelesko commented Jul 19, 2024

Implement missing host math funcs

* Compiling the bitode library to host code leads to linking errors
some of the OpenCL natives being used in the library code are not
available for the CPU, resulting in linking errors

* OCML does not meant to be compiled in C++ mode
for this, we create a drop-in opencl header defining the missing
datatypes

* Since OCML uses headers in the same directory as the source files,
we must copy the necessary source files into a new directory so that
our replacement headers get picked up instead of the originals

* Implement a new header for mapping math funcs to host-side ocml

* Discover an additional way to trigger 128 bit error

* Discover a discrepancy in host and device func results

@pvelesko pvelesko force-pushed the missing-host-funcs branch 4 times, most recently from 49e81fd to b04d184 Compare July 23, 2024 10:58
@pvelesko pvelesko marked this pull request as ready for review July 23, 2024 11:37
* Compiling the bitode library to host code leads to linking errors
some of the OpenCL natives being used in the library code are not
available for the CPU, resulting in linking errors

* OCML does not meant to be compiled in C++ mode
for this, we create a drop-in opencl header defining the missing
datatypes

* Since OCML uses headers in the same directory as the source files,
we must copy the necessary source files into a new directory so that
our replacement headers get picked up instead of the originals

* Implement a new header for mapping math funcs to host-side ocml

* Discover an additional way to trigger 128 bit error

* Discover a discrepancy in host and device func results
@pvelesko pvelesko merged commit 29ce59f into main Jul 24, 2024
31 checks passed
@pvelesko pvelesko deleted the missing-host-funcs branch July 24, 2024 05:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant