Properly annotate Intel USM kernels #911
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pvelesko
force-pushed
the
cpu-usm
branch
3 times, most recently
from
329b4c7
to
04990b1
Compare
Have to annotate kernels with all types CL_KERNEL_EXEC_INFO_INDIRECT_HOST_ACCESS_INTEL CL_KERNEL_EXEC_INFO_INDIRECT_DEVICE_ACCESS_INTEL CL_KERNEL_EXEC_INFO_INDIRECT_SHARED_ACCESS_INTEL since a kernel might have allocations of varied types
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Once kernels are annotated with
CL_KERNEL_EXEC_INFO_USM_PTRS_INTEL, they need to be annotated withCL_KERNEL_EXEC_INFO_INDIRECT_DEVICE_ACCESS_INTEL, if the arguments inside the kernel which might see indirect access are allocated asdevice. If multiple types of allocations are used we have to have multiple calls toclSetKernelExecInfo.Optimally, we would inspect the kernel to figure out exactly what kind of allocations have been used but with indirect access it's complicated.