-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Github Actions for macos system update #948
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really, it's a zero-character modification? Thanks for dealing with this (over and over).
It's not fixed yet, need to trigger github actions to debug. First mod was adding a trivial change to create the PR, still trying to figure out what's happening. Unfortunately, I need to debug in the PR. |
I see. Would it not work to PR into another branch of your own? |
True, I could test it in my fork first. That would require I explicitly turn on the github actions on that branch in my fork. Sort of easier just to do it in regular PR as long as others don't mind too much :) |
This is ready for merge. |
Github Actions broke again after default macos system update. Clang was not picking up the C system files. Had to change the implementation and add -isysroot to the CFLAGS option. At the same time, removed prior implementation where the system files were linked into /usr/local/include, this was no longer working.
Github Actions broke again after default macos system update. Clang was not picking up the C system files. Had to change the implementation and add -isysroot to the CFLAGS option. At the same time, removed prior implementation where the system files were linked into /usr/local/include, this was no longer working.
PR checklist
Fix latest problem with Github Actions for macos system update
apcraig
TBD
Github Actions broke again after default macos system update.
Clang was not picking up the C system files. Had to change the implementation and add -isysroot to the CFLAGS option. At the same time, removed prior implementation where the system files were linked into /usr/local/include, this was no longer working.