Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update guide.sh to fix output count on line 196 #160

Merged
merged 1 commit into from
May 16, 2024

Conversation

ZacharyWills
Copy link

No description provided.

@benlee0423
Copy link

benlee0423 commented May 14, 2024

I think this fix only applicable when we have nested directories in outputs directory. Current guide script only put output files in outputs directory? We can hold off this until 006 input file is ready to use?

UA-QG4YJKY:input benjaminlee$ ls outputs/*/* | wc -l
ls: outputs/*/*: No such file or directory
       0

@ZacharyWills
Copy link
Author

Yep, just making it ready for the 006 data set.

@shahab122
Copy link

shahab122 commented May 14, 2024

AWI-006 Input Map:
Case Study Map for the Provo River Basin, UT
image

@arpita0911patel arpita0911patel merged commit a9dd792 into main May 16, 2024
9 checks passed
@jameshalgren
Copy link
Member

jameshalgren commented May 16, 2024

@ZacharyWills @arpita0911patel
In the changed line,
The quoted string doesn't expand the wildcard star * character.
e.g.,

CloudInfra % ls "*"
"*": No such file or directory (os error 2)
CloudInfra % ls '*'
"*": No such file or directory (os error 2)
CloudInfra % ls *
contribute.md  guide.sh  README.md  viewOnTethys.sh

config:
awi_simplified_realization.json
.
.
.
CloudInfra %

We might need to revert -- working on a suggested fix... (probably just an escape for the wildcards or something...)

This seems to work. Using find gets away from some of the wildcard expansion pitfalls and it also allows us to specifically filter to files (so we are not counting any directories as an output.)

Final_Outputs_Count=$(find $HOST_DATA_PATH/outputs/ -type f | wc -l)

@hariteja-jajula

@benlee0423 benlee0423 deleted the ZacharyWills-patch-1 branch November 22, 2024 06:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants