Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bottom margin to button in report-mardown-editor #258

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add bottom margin to button in report-mardown-editor #258

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
10bcca5
Add bottom margin to button in report-mardown-editor
pierreconti Jul 9, 2021
1a4aff1
padding in .buttons, keep distance with block controls under it
pierreconti Jul 18, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion assets/css/WorkflowEditor/Report/_mixins.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
justify-content: flex-end;

button {
margin: 0.5em 0 0 0.5em;
margin: 1em 0 1em 1em;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @pierreconti,

I find the margin-bottom confusing: it does not collapse with the .add-block-prompt .actions margin-top below it. Is this intentional?

On hover, the top buttons are flush with the top of the left-hand blue bar; but the bottom buttons aren't flush with the bottom, because of this new margin-bottom. Is that intentional?

Your answers will decide how we rewrite this code. margin is "quick-and-confusing"; padding is legible but cumbersome. Now that I'm confused, it's time to switch to using padding :).

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok I switched to padding while keeping the distance consistent above and below .buttons

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pierreconti Please answer my question:

On hover, the top buttons are flush with the top of the left-hand blue bar; but the bottom buttons aren't flush with the bottom, because of this new margin-bottom. Is that intentional?

}
}
}