Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adding modal to edit fismasystems #100

Merged
merged 9 commits into from
Dec 19, 2024
Merged

Conversation

ATNoblis
Copy link
Collaborator

@ATNoblis ATNoblis commented Nov 27, 2024

Summary

Adding a modal that allows admins to edit fisma systems

Ordered the pillar functions in questionnaire modal

removed dependabot from imbedded ui workflow

closes #90
closes #105

Added

Modal to edit fisma system

Modal to confirm changes if a user does not save their changes of editing a fisma system.

Changes

Fisma Table to update the row data if edits to fisma system were made.

Test

(ADMIN) click on the icon in fisma table to edit a fisma system. Make changes and click 'save' to save changes.

if changes are made and admin closes the modal before saving the change, a confirmation modal will appear.

Changes that are made which are invalid to the endpoint will prompt user to enter a valid input.

  • to test this remove characters from the fismauid OR when adding a new system to have an invalid fismauid

To add a new fisma system, please click on the kebab icon next to your name (admin). There is a menu to add a fisma system.

For the ordered pillar functions in questionnaire modal

  • Open questionnaire modal to check order of functions

@ATNoblis ATNoblis added the enhancement New feature or request label Nov 27, 2024
@ATNoblis ATNoblis self-assigned this Nov 27, 2024
@ATNoblis ATNoblis marked this pull request as ready for review December 11, 2024 17:24
…validate user input before saving. Prompt the user to provide valid input if the current input is invalid.
.github/workflows/ui.yml Outdated Show resolved Hide resolved
src/components/ErrorBoundary.test.tsx Outdated Show resolved Hide resolved
@ATNoblis ATNoblis merged commit 67bc275 into main Dec 19, 2024
5 checks passed
@ATNoblis ATNoblis deleted the feat-edit-fismasystem-modal branch December 19, 2024 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ui: order the functions for each pillar in questionnare modal ui: modal to add and edit fismasystems
2 participants