-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: adding modal to edit fismasystems #100
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…validate user input before saving. Prompt the user to provide valid input if the current input is invalid.
talentedmrjones
requested changes
Dec 19, 2024
talentedmrjones
approved these changes
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adding a modal that allows admins to edit fisma systems
Ordered the pillar functions in questionnaire modal
removed
dependabot
from imbedded ui workflowcloses #90
closes #105
Added
Modal to edit fisma system
Modal to confirm changes if a user does not save their changes of editing a fisma system.
Changes
Fisma Table to update the row data if edits to fisma system were made.
Test
(ADMIN) click on the icon in fisma table to edit a fisma system. Make changes and click 'save' to save changes.
if changes are made and admin closes the modal before saving the change, a confirmation modal will appear.
Changes that are made which are invalid to the endpoint will prompt user to enter a valid input.
fismauid
OR when adding a new system to have an invalidfismauid
To add a new fisma system, please click on the kebab icon next to your name (admin). There is a menu to add a fisma system.
For the ordered pillar functions in questionnaire modal