[WNMGDS-2864] Add utility actions pattern guidance page #3198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jack-ryan-nava-pbc
added
Impacts: Documentation
jack-ryan-nava-pbc
requested review from
zarahzachz,
pwolfert,
kim-cmsds,
tamara-corbalt,
andream-cmsds and
malloryiden
pwolfert
reviewed
Aug 12, 2024
jack-ryan-nava-pbc
changed the title
This reverts commit fd0f3bc.
* Add PrintIcon component. * Removed fillColor attribute from PrintIcon componet and removed lint from incons.stories.tsx
* Adds Email and RSS icons.
* Adds Link and What's New Icons
* Exchange (') for curly (’)
jack-ryan-nava-pbc
changed the title
zarahzachz
reviewed
Aug 19, 2024
kim-cmsds
reviewed
Aug 19, 2024
kim-cmsds
reviewed
Aug 19, 2024
kim-cmsds
reviewed
Aug 19, 2024
kim-cmsds
reviewed
Aug 19, 2024
* Run prettier on json files * Update lint-staged config to format json files
* Export vars and function needed in release script * Reorder imports and add new reviewers * Add new utility functions used by bumpVersions * Handle staging files properly * Export correct function from versions * export readJson so maybe we capture new line with read file' ' * big refactor add comments break up inline for loop and associated functions * Wrap removal of top level package json in try catch and uncomment woopsie * Add maybe more helpful comment * Further refactoring * Looks like a big refactor but basically moved all code to a new file * Adding functionality so we don't lose newline at end of json files * [NO-TICKET] Automatically format json files (#3206) * Run prettier on json files * Update lint-staged config to format json files * Undo new line addition when writing json * Fix typo * Move version number into our main function to make usage clearer --------- Co-authored-by: Patrick Wolfert <patrick.wolfert@adhocteam.us>
* Publish - @cmsgov/design-system@11.0.0-beta.0 - @cmsgov/ds-cms-gov@11.0.0-beta.0 - @cmsgov/ds-healthcare-gov@15.0.0-beta.0 - @cmsgov/ds-medicare-gov@13.0.0-beta.0 * [NO-TICKET] Manually updates "@cmsgov/design-system" version in package dependencies (#3201) manually updates dependency of "@cmsgov/design-system" version * Reverts design-system-tokens version back to 0.0.1 --------- Co-authored-by: Kim Niedermaier <kimniedermaier+cmsds@navapbc.com> Co-authored-by: Patrick Wolfert <patrick.wolfert@adhocteam.us>
* Basic migration script for v11 variable/class changes * These two variables weren't removed! We need to update our release notes, because that was a mistake * Fix syntax error (stray single quote) * Fix regex group not getting printed in the replacement text * Mention the migration script in the blog post and explain how to use it
…gh `HelpDrawer` (#3210) Fix `onAnalyticsEvent` prop bleeding into `dialog` DOM elements through `HelpDrawer` Without this fix, the unit test I added will print errors to the console like this: ``` console.error Warning: Unknown event handler property `onAnalyticsEvent`. It will be ignored. at dialog at NativeDialog (/Users/patrickwolfert/Projects/design-system/packages/design-system/src/components/NativeDialog/NativeDialog.tsx:38:3) at Drawer (/Users/patrickwolfert/Projects/design-system/packages/design-system/src/components/Drawer/Drawer.tsx:73:5) at HelpDrawer (/Users/patrickwolfert/Projects/design-system/packages/design-system/src/components/HelpDrawer/HelpDrawer.tsx:13:11) ```
Be more informative about what `defaultMenuLinks` returns in the types
Previously the return type was `{}`, which is useless to teams trying to use that functions themselves
update v11 blog post to remove reference to removing the privacy settings dialog
* filter out the core design system * Add comment and make conditional more readable * make conditional more readable
* Initial set of default values added to props tables * Updated storybook snaps
* Update all themes to make inline tool tips black * Udpate playwright vrt snapshots * Updating css snapshots * Updated css themes and custom tooltip scss styling to maybe no avail * setting tooltip color to match base color of surrounding text * Restore weirdly changed snapshots curious if CI browser tests pass * [WNMGDS-2875] Fix Release script take 2 (#3205) * Export vars and function needed in release script * Reorder imports and add new reviewers * Add new utility functions used by bumpVersions * Handle staging files properly * Export correct function from versions * export readJson so maybe we capture new line with read file' ' * big refactor add comments break up inline for loop and associated functions * Wrap removal of top level package json in try catch and uncomment woopsie * Add maybe more helpful comment * Further refactoring * Looks like a big refactor but basically moved all code to a new file * Adding functionality so we don't lose newline at end of json files * [NO-TICKET] Automatically format json files (#3206) * Run prettier on json files * Update lint-staged config to format json files * Undo new line addition when writing json * Fix typo * Move version number into our main function to make usage clearer --------- Co-authored-by: Patrick Wolfert <patrick.wolfert@adhocteam.us> * Undoing accidental hover styling change --------- Co-authored-by: Patrick Wolfert <patrick.wolfert@adhocteam.us>
This reverts commit fd0f3bc.
andream-cmsds
approved these changes
Sep 9, 2024
| ### Usage | ||
|
|
||
| - Utility actions are ghost buttons for available actions that do not take priority over primary or secondary call-to-actions (CTAs). | ||
| - Placement should be in the page header and top, right aligned. |
There was a problem hiding this comment.
Just a suggestion, but it might be clearer to write "top-right aligned" vs "top, right aligned."
There was a problem hiding this comment.
I agree, but since this is approved copy we'll keep it as is. Thanks!
tamara-corbalt
approved these changes
Sep 10, 2024
jack-ryan-nava-pbc
deleted the
jryan/wnmgds-2864-utility-actions-guidance
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Ticket
Added new guidance page for the utility actions pattern.
Note
The design will differ on this branch because the EmailIcon is being imported from the local Doc Site component rather than the Design System. A ticket is up to fix this issue.
How to test
Checklist
[WNMGDS-####] Titleor [NO-TICKET] if this is unticketed work.Type(only one) label for this PR, if it is a breaking change, label should only beType: BreakingImpacts, multiple can be selected.This is a change to documentation:
Screenshots:
With EmailIcon collision:
Without EmailIcon collision:
