merge CMake build process and Python wrapper shared library into main #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @adamant-pwn. Is this only the CMake integration or more? |
adamant-pwn
commented
Dec 9, 2024
| reg0->maps[m].tags); | ||
| if(reg0->maps[m].tags) {free(reg0->maps[m].tags); reg0->maps[m].tags = NULL;} | ||
| } | ||
| if(!p->su_stop || k < p->su_stop){ |
There was a problem hiding this comment.
Most changes in this file are trivial (i.e. remove static), but this one looks like a refactoring that was done in tflite2 branch, but not in main. I essentially copied this block from tflite2, so it'd be nice for @canfirtina to confirm that there were no substantial changes from the main that were overwritten.
|
@canfirtina this includes:
What it does not include yet:
|
adamant-pwn
commented
Dec 9, 2024
| if(RUCLIENT_ENABLED) | ||
| set_target_properties(${TARGET_NAME} PROPERTIES CXX_STANDARD 20) | ||
| target_compile_definitions(${TARGET_NAME} PRIVATE RUCLIENT_ENABLED) | ||
| target_sources(${TARGET_NAME} PRIVATE rawhash_ruclient.cpp) |
There was a problem hiding this comment.
As I'm not sure about whether we plan to keep using rawhash_ruclient.cpp or stick to Python client, we might also want to drop this file altogether. Any thoughts?
Closed
adamant-pwn
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried my best to only salvage what was really necessary from tflite2 branch. I'd really appreciate some external review and verification that it works as intended after the merge.