-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support rendering partial markdown and improve performance #73
base: promplate-demo
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
审核指南 by Sourcery此拉取请求实现了重大更改,以改进 Markdown 渲染和代码块功能。主要更改包括从 时序图sequenceDiagram
participant C as Component
participant SM as SolidMarkdown
participant RP as RemarkPlugins
participant RH as RehypePlugins
participant CB as CodeBlock
C->>SM: Render markdown
SM->>RP: Process with remark plugins
SM->>RH: Process with rehype plugins
SM->>CB: Render code blocks
CB-->>SM: Return rendered code
SM-->>C: Return rendered markdown
文件级更改
提示和命令与 Sourcery 互动
自定义您的体验访问您的仪表板以:
获取帮助Original review guide in EnglishReviewer's Guide by SourceryThis pull request implements significant changes to improve markdown rendering and code block functionality. The main changes include switching from Sequence DiagramsequenceDiagram
participant C as Component
participant SM as SolidMarkdown
participant RP as RemarkPlugins
participant RH as RehypePlugins
participant CB as CodeBlock
C->>SM: Render markdown
SM->>RP: Process with remark plugins
SM->>RH: Process with rehype plugins
SM->>CB: Render code blocks
CB-->>SM: Return rendered code
SM-->>C: Return rendered markdown
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
✅ Deploy Preview for promplate-demo ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
嘿 @CNSeniorious000 - 我已经审查了你的更改,看起来很棒!
这是我在审查期间查看的内容
- 🟡 一般问题:发现1个问题
- 🟢 安全性:一切看起来都很好
- 🟢 测试:一切看起来都很好
- 🟢 复杂性:一切看起来都很好
- 🟢 文档:一切看起来都很好
帮助我变得更有用!请在每条评论上点击 👍 或 👎,我将使用反馈来改进你的审查。
Original comment in English
Hey @CNSeniorious000 - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Still,
|
c266328
to
d54381f
Compare
Created a PR to the upstream: andi23rosca/solid-markdown#36 |
d54381f
to
cba7def
Compare
cba7def
to
1fc3bc4
Compare
bb3d9b4
to
0d90f65
Compare
b74773a
to
44c5db8
Compare
47772a0
to
1b0c394
Compare
2d5a210
to
987af17
Compare
Use
solid-markdown
to parse and render markdown without frequently updating DOMSourcery 的总结
用
solid-markdown
替换现有的 markdown 渲染方法,以支持部分 markdown 渲染,并通过最小化 DOM 更新来提高性能。重构代码以使用带有remark
和rehype
插件的unified
,并更新 API 模型版本。新功能:
solid-markdown
库渲染部分 markdown 的支持,增强 markdown 渲染的灵活性。增强:
solid-markdown
进行 markdown 解析和渲染,减少频繁的 DOM 更新以提高性能。remark
和rehype
插件的unified
,以提高可扩展性和可维护性。杂务:
Original summary in English
Summary by Sourcery
Replace the existing markdown rendering approach with
solid-markdown
to support partial markdown rendering and improve performance by minimizing DOM updates. Refactor the code to useunified
withremark
andrehype
plugins, and update the API model version.New Features:
solid-markdown
library, enhancing the flexibility of markdown rendering.Enhancements:
solid-markdown
for markdown parsing and rendering.unified
withremark
andrehype
plugins for better extensibility and maintainability.Chores: