Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved the dark theme #360

Merged
merged 10 commits into from
Sep 27, 2024
Merged

Improved the dark theme #360

merged 10 commits into from
Sep 27, 2024

Conversation

ShamaKamina
Copy link
Contributor

@ShamaKamina ShamaKamina commented Sep 27, 2024 •
edited
Loading

Changes I made:

  • Ensured the subscription modal adheres to the theme
  • the more menu item adheres to the theme
  • the resolution modal adheres to the theme
  • the Notifications page adheres to the theme
  • Also fixed the forecasting message
  • Changed "Reports" to "Statistics"
  • Changed the "Get report" Icon (can change the icon if you dont like the pie chart)

Also the leaderboard component seems fine to me in dark mode, not sure why it was crazy for CBC same for the logo.

Things left:

  • The analytics page. Yeah that one IDK

But yeah accept my PR that has no bugs homies

@vercel Vercel
Copy link

vercel bot commented Sep 27, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
the-republic ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 27, 2024 5:57pm

TebogoYungMercykay
TebogoYungMercykay approved these changes Sep 27, 2024
View reviewed changes
Copy link
Contributor

@TebogoYungMercykay TebogoYungMercykay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice.

@TebogoYungMercykay TebogoYungMercykay merged commit 18b9549 into develop Sep 27, 2024
16 checks passed
@TebogoYungMercykay TebogoYungMercykay deleted the feature/darkTheme branch September 30, 2024 09:47
@TebogoYungMercykay TebogoYungMercykay added this to the Demo 4 milestone Sep 30, 2024
@TebogoYungMercykay TebogoYungMercykay mentioned this pull request Sep 30, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TebogoYungMercykay TebogoYungMercykay TebogoYungMercykay approved these changes

@hlokomani hlokomani Awaiting requested review from hlokomani

@IRIA7 IRIA7 Awaiting requested review from IRIA7

@MulisaMusehane MulisaMusehane Awaiting requested review from MulisaMusehane

Assignees
No one assigned
Labels
priority: High scope: Frontend
Projects
None yet
Milestone
Demo 4
Development

Successfully merging this pull request may close these issues.
2 participants
@ShamaKamina @TebogoYungMercykay