Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Intake conversion Model_Resolution_Comparison #362

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

rbeucher
Copy link
Contributor

@rbeucher rbeucher commented Jun 6, 2024

Following the discussion in issue #313, we propose converting the recipes to use Intake, given that the Cookbook is no longer supported and the ACCESS-NRI Intake catalog is now available.

A few months ago, @max-anu began working on this transition. This pull request contains the changes @max-anu made to the notebook specified in the title.

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@navidcy
Copy link
Collaborator

navidcy commented Jul 19, 2024

I tried to merge main here and got so many conflicts that perhaps it's easier to start from scratch...

@anton-seaice
Copy link
Collaborator

I liked having this open at least to track that this notebook hasn't been looked at yet, even if we plan on starting again.

@navidcy
Copy link
Collaborator

navidcy commented Jul 28, 2024

Let's open a new one!

@navidcy
Copy link
Collaborator

navidcy commented Jul 28, 2024

hm... ok, perhaps what I'm suggesting is more work...
But do we want to have a PR open just for a reminder? An issue should be doing that purpose, right?

@navidcy
Copy link
Collaborator

navidcy commented Jul 28, 2024

I only closed it because I couldn't resolve comments and it's been a while and nobody seemed to be picking this up. But if anybody wants to work on it please reopen and code away

@navidcy
Copy link
Collaborator

navidcy commented Jul 29, 2024

I liked having this open at least to track that this notebook hasn't been looked at yet, even if we plan on starting again.

I updated #313 (comment) to keep track which examples were converted and which not. Does this work for you?

@anton-seaice anton-seaice reopened this Aug 1, 2024
@anton-seaice anton-seaice marked this pull request as draft August 1, 2024 10:41
@anton-seaice anton-seaice self-assigned this Aug 1, 2024
@anton-seaice anton-seaice force-pushed the INTAKE_Model_Resolution_Comparison branch from 733646b to fde0cbf Compare August 1, 2024 10:45
Copy link

review-notebook-app bot commented Aug 1, 2024

View / edit / reply to this conversation on ReviewNB

anton-seaice commented on 2024-08-01T10:51:54Z
----------------------------------------------------------------

Line #12.        gl.xlabels_top = False

Why does this line not work?


@anton-seaice anton-seaice marked this pull request as ready for review August 2, 2024 06:00
@anton-seaice
Copy link
Collaborator

This is ready for review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants