Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Intake conversion Zonally_Averaged_Global_Meridional_Overturning_Circulation #374

Conversation

rbeucher
Copy link
Contributor

@rbeucher rbeucher commented Jun 6, 2024

Following the discussion in issue #313, we propose converting the recipes to use Intake, given that the Cookbook is no longer supported and the ACCESS-NRI Intake catalog is now available.

A few months ago, @max-anu began working on this transition. This pull request contains the changes @max-anu made to the notebook specified in the title.

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@adele-morrison adele-morrison requested review from adele-morrison and removed request for adele-morrison July 1, 2024 03:40
@navidcy
Copy link
Collaborator

navidcy commented Jul 7, 2024

Note that there is also #324 which converts this example to more model-agnostic and also uses pint... But it got stuck-stale... I'm having dask problems (like most of my python-xarray-dask life!)

@anton-seaice
Copy link
Collaborator

Should we finalise #324 before working on this?

@anton-seaice anton-seaice marked this pull request as draft July 8, 2024 06:28
@navidcy
Copy link
Collaborator

navidcy commented Jul 8, 2024

Either or. It doesn’t really matter, right?
We should finalise which ever is easier first. Perhaps the conversion to intake is more straightforward?

@anton-seaice
Copy link
Collaborator

Ah. In addition this PR is stuck because we don't have OM4_025 or other mom6 runs in the intake catalog yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

4 participants