Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Intake conversion Spatial_selection #379

Merged
merged 8 commits into from
Jul 19, 2024
Merged

Conversation

rbeucher
Copy link
Contributor

@rbeucher rbeucher commented Jun 6, 2024

Following the discussion in issue #313, we propose converting the recipes to use Intake, given that the Cookbook is no longer supported and the ACCESS-NRI Intake catalog is now available.

A few months ago, @max-anu began working on this transition. This pull request contains the changes @max-anu made to the notebook specified in the title.

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link

review-notebook-app bot commented Jun 17, 2024

View / edit / reply to this conversation on ReviewNB

anton-seaice commented on 2024-06-17T00:56:42Z
----------------------------------------------------------------

@aidanheerdegen - Is it correct to refer to the 1D coordinates as 'latitude/longitude' as they are not true latitude and longitudes? Shouldn't they just be X/Y (or possibly 'grid_latitude/grid_longitude' ?


@navidcy
Copy link
Collaborator

navidcy commented Jun 17, 2024

hmmmm.... not X, Y... right?

@anton-seaice
Copy link
Collaborator

I made some changes so this runs, happy for someone to review now and leave the question about 1D coordinate names for later!

Copy link

review-notebook-app bot commented Jun 24, 2024

View / edit / reply to this conversation on ReviewNB

anton-seaice commented on 2024-06-24T06:19:26Z
----------------------------------------------------------------

Line #1.    cat_subset = catalog[expt]

Is "datastore" a more correct name than "cat_subset" ?


@navidcy
Copy link
Collaborator

navidcy commented Jun 24, 2024

cat_subset means nothing to me... so yes, anything bit more verbose and self-explanatory is better!

@aidanheerdegen
Copy link
Contributor

@aidanheerdegen - Is it correct to refer to the 1D coordinates as 'latitude/longitude' as they are not true latitude and longitudes? Shouldn't they just be X/Y (or possibly 'grid_latitude/grid_longitude' ?

They are true latitude and longitudes, just not correct for the data in the file.

I think GFDL might use "nominal latitude/longitude"? I think X/Y is misleading, and they are lons/lats.

@anton-seaice
Copy link
Collaborator

This is ready for review

Copy link
Collaborator

@navidcy navidcy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! thanks!!

@anton-seaice anton-seaice merged commit 76f747d into main Jul 19, 2024
3 checks passed
@anton-seaice anton-seaice deleted the INTAKE_Spatial_selection branch July 19, 2024 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

5 participants