Intake conversion Regridding example; take #2 #413
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
|
Took the opportunity to rename/retitle the notebook as per discussion in #412 |
|
View / edit / reply to this conversation on ReviewNB anton-seaice commented on 2024-07-08T07:05:56Z Line #1. import pandas as pd This isn't used |
|
View / edit / reply to this conversation on ReviewNB anton-seaice commented on 2024-07-08T07:05:56Z Line #5. ssh_1 = ds['sea_level'].sel(time=slice('2000-01-01', '2001-12-31')).cf.chunk({'time': 'auto', 'longitude': -1, 'latitude': -1})
I suggest we just |
|
View / edit / reply to this conversation on ReviewNB anton-seaice commented on 2024-07-08T07:05:57Z Line #5. ssh_025 = ds['sea_level'].sel(time=slice('2000-01-01', '2001-12-31')).cf.chunk({'time': 'auto', 'longitude': -1, 'latitude': -1})
I suggest we just navidcy commented on 2024-07-09T12:19:12Z I left the chunck as it might be needed if you load a larger data array that you can't anton-seaice commented on 2024-07-10T00:27:59Z It doesn't appear to have made any difference to the times (or perhaps its slower?) so without .load is fine navidcy commented on 2024-07-11T14:20:22Z OK, done |
|
View / edit / reply to this conversation on ReviewNB anton-seaice commented on 2024-07-08T07:05:58Z Line #5. ssh_010 = ds['sea_level'].sel(time=slice('2000-01-01', '2001-12-31')).cf.chunk({'time': 'auto', 'longitude': -1, 'latitude': -1})
I suggest we just |
|
View / edit / reply to this conversation on ReviewNB anton-seaice commented on 2024-07-08T07:05:58Z Line #4. regridder_1degACCESSOM2_1deg = xesmf.Regridder(ds_in_1deg, ds_out, 'bilinear', periodic=True, Can you run black or something on this notebook? The formatting is kind of messy navidcy commented on 2024-07-09T12:19:34Z I don't know how to do that! Can you do it perhaps? navidcy commented on 2024-07-09T12:20:00Z I know how to run black on anton-seaice commented on 2024-07-10T00:27:17Z Yes correct - its in conda/analysis3 so you should be able to run that in the ARE terminal or a Gadi login
navidcy commented on 2024-07-11T14:20:55Z hm... I can't... can we leave this for some other time? |
|
I think this notebook might not need dask at all actually. |
Nevermind .. it does need dask. |
|
@anton-seaice, thanks for the comments!I think I addressed all of them! |
But what if you load more than one snapshot of fields you wanna regrid? |
|
I left the chunck as it might be needed if you load a larger data array that you can't View entire conversation on ReviewNB |
|
I don't know how to do that! Can you do it perhaps? View entire conversation on ReviewNB |
|
I know how to run black on View entire conversation on ReviewNB |
|
Yes correct - its in conda/analysis3 so you should be able to run that in the ARE terminal or a Gadi login
View entire conversation on ReviewNB |
|
It doesn't appear to have made any difference to the times (or perhaps its slower?) so without .load is fine View entire conversation on ReviewNB |
|
View / edit / reply to this conversation on ReviewNB anton-seaice commented on 2024-07-10T00:28:48Z Line #1. %%time There doesn't appear to be a need to time these three cells navidcy commented on 2024-07-11T14:21:09Z deal |
|
View / edit / reply to this conversation on ReviewNB anton-seaice commented on 2024-07-10T00:32:24Z Maybe change 'the same 1 degree longitude-latitude grid. '
to "a 1 degree longitude-latitude grid with regular spacing." ?
Maybe "In this example, " is better than "In particular, " navidcy commented on 2024-07-11T14:19:58Z Done |
|
Apologies for the double-review. This is very close :) |
|
@anton-seaice, review is a continuing process! we expect review comments until the community is happy -- there is no quota on reviews! |
…pes into ncc/intake_regridding
|
@anton-seaice I'll skip black. I get this: (base) nc3020@gadi-login-07:~/gdata/cosima-recipes$ black Examples/Horizontal_Regridding.ipynb
Skipping .ipynb files as Jupyter dependencies are not installed.
You can fix this by running ``pip install "black[jupyter]"``
No Python files are present to be formatted. Nothing to do 😴and even after installing via |
|
I did everything except the black formatting. We could set up a GitHub action to apply black to all notebooks? I'm not sure if this is a good idea... Sometimes black makes things less pretty. It's also subjective... |
|
Done View entire conversation on ReviewNB |
|
OK, done View entire conversation on ReviewNB |
|
hm... I can't... can we leave this for some other time? View entire conversation on ReviewNB |
|
deal View entire conversation on ReviewNB |
|
View / edit / reply to this conversation on ReviewNB anton-seaice commented on 2024-07-11T23:12:12Z We can get rid of the geolon/ geolat warnings by either not renaming 'geolon' to longitude and 'geolat' to latitde, or by updating the attributes when we do? Thoughts?
xesmf should understand cf attributes, so i think we can leave the names as geolon/geolat and it will know what to do navidcy commented on 2024-07-19T03:08:36Z done |
Are you sure about this? I thought these warnings are related to #150 and #212 because some coords are missing from the 1deg grid saved in |
|
Im moderately confident its because of these lines: but the cf-attributes still refer to 'geolon_t' and 'geolat_t', which don't exist, so theres an error ? |
|
done View entire conversation on ReviewNB |
|
@anton-seaice I believe this is ready |
…pes into ncc/intake_regridding
navidcy
changed the title
I tried to work with #366 but I couldn't resolve the merge conflicts...
So I opened this PR to convert the Regridding example to use Intake instead of cookbook.
Also this PR deals with #418 regarding the Regridding example.