Added an example for along-isobath averaging

[taimoorsohail]

Hi, I am posting a new Contributed Example which averages properties along an isobath - useful for Antarctic margins analysis. Let me know if you have thoughts!

closes #397

[review-notebook-app]

Check out this pull request on 

See visual diffs & provide feedback on Jupyter Notebooks.

---

Powered by ReviewNB

[navidcy]

Seems that you added two files?

[taimoorsohail]

Yeah sorry - I accidentally included a random change I made to the ContributedExamples/Cross-slope_section_potrho_cc.ipynb file - please delete if possible before pushing the new file :)

[navidcy]

@taimoorsohail is there a reason you wanted to make this a "Contributed Example"?

We decided to just have "Examples" and they should all be documented and in good shape; see #407.

[taimoorsohail]

Ah sorry, I didn't know that we had moved on! Yes happy to add it to "Examples" if everyone is happy with the level of documentation and commenting.

[navidcy]

if everyone is happy with the level of documentation and commenting.

We'll let the review process determine that. :)

[adele-morrison]

Hey @taimoorsohail, out of interest, is it necessary to use st_edges_ocean for the bins? Would it be possible in theory to use a more even binning (say spaced every 50m in isobath depth) and then use ht/hu for computing the histogram?

[adele-morrison]

Currently the time average is done just before plotting, but the time information is not used. Perhaps time averaging and loading earlier could make it run faster?

[adele-morrison]

I'm wondering if we can get away with only one set of plots? Since they are identical except for the x-axis labels. Would having different example axis labels on different sub-panels be too confusing?

Reply via ReviewNB

[taimoorsohail]

Yes that is definitely possible. I tend to maximise all possible combinations when writing out an example, just to account for more possible use-cases. But yes, In theory we could just do a 1x3 plot, with each subplot showing the three different x-axes (i.e., ht_bins, normed_area and pseudo-lat) for a single variable (e.g. temperature). I think the different x-axis labels might be confusing but yes, also a possibility.

[adele-morrison]

Also, if you edit your top post to add:
closes https://github.com/COSIMA/cosima-recipes/issues/397,
it will automatically close the issue when this is merged.

[taimoorsohail]

Hey @taimoorsohail, out of interest, is it necessary to use st_edges_ocean for the bins? Would it be possible in theory to use a more even binning (say spaced every 50m in isobath depth) and then use ht/hu for computing the histogram?

Hey @adele-morrison! In theory, it should be OK. I had some issues masking ht/hu with st_edges_ocean for the bins, as ht and hu cover a larger range of depths than the bottom depth of the variables (see https://forum.access-hive.org.au/t/difference-between-bottom-bathymetry-variable-ht-and-actual-data-in-access-om2-01/2221). This meant I was getting more "jagged" averages which only really affected the "prettiness" of the visualisation. I didn't try reducing the bin spacing though.

Currently the time average is done just before plotting, but the time information is not used. Perhaps time averaging and loading earlier could make it run faster?

Won't time-averaging after binning account for the temporal variability within each bin? Whereas time-averaging before binning would get rid of that? I'm not sure...

[navidcy]

this cell looks like the same as the cell above?

then why not making it a function and just call it twice with different inputs?

Reply via ReviewNB