-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplified examples for plotting cross-section and along slope velocity #420
base: main
Are you sure you want to change the base?
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
thanks @ongqingyee!! I merged main and simplified a bit -- very minor things. This is ready to be reviewed... Anybody? |
@@ -0,0 +1,967 @@ | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can delete "example" in title. I think we've been trying to make the titles the same as the notebook filenames.
Reply via ReviewNB
@@ -0,0 +1,967 @@ | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Anything we can do about these RuntimeWarnings? Maybe at the very least we could add a comment about why they are there and that they are ok to ignore?
Reply via ReviewNB
View / edit / reply to this conversation on ReviewNB adele-morrison commented on 2024-07-24T10:34:42Z "cross-slopE" |
View / edit / reply to this conversation on ReviewNB adele-morrison commented on 2024-07-24T10:34:43Z Line #6. pot_rho_2 Does the array need to be printed out here? |
View / edit / reply to this conversation on ReviewNB adele-morrison commented on 2024-07-24T10:34:44Z Line #3. pot_rho_2 Again, do we need to print the array here? |
View / edit / reply to this conversation on ReviewNB adele-morrison commented on 2024-07-24T10:34:44Z Line #3. pot_temp Also here? |
View / edit / reply to this conversation on ReviewNB adele-morrison commented on 2024-07-24T10:34:45Z Line #5. #pot_rho_2 = grid_depth.interp(grid_depth.interp(pot_rho_2, axis = 'X').chunk({'yt_ocean': 500}) , axis = 'Y', boundary = 'extend')#.sel(yu_ocean=lat_slice).sel(st_ocean=slice(0,depth)) Is this commented code needed? |
View / edit / reply to this conversation on ReviewNB adele-morrison commented on 2024-07-24T10:34:46Z Line #3. pot_rho_2_section.load() Could add a semicolon after this to suppress printing. |
Added some minor comments, but otherwise looks good to me @ongqingyee! |
Original
Examples/Cross-slope_section.ipynb
now separated into two scripts. Any advice on making it model agnostic would be great - having to manually drop geolat and geolon for only one model does not seem optimal.