-
Notifications
You must be signed in to change notification settings - Fork 241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace search progress dialog with an in-place progress bar #509
Conversation
f8bee01
to
20e1910
Compare
@vifactor There is already a progress bar at the right bottom. Could you use this one instead of a new one? |
If I remember correctly (no access to the code ATM), the progress bar at the right bottom is used to display indexing progress. The indexing is run in a separate thread, while search is run in the main thread, so they (can) happen concurrently/in parallel. If it is the case, I'm not sure we can combine both progress reports in a single bar. |
A signal/slot concept is used to separate the access to the progress bar. What we must achieve that no of the parallel running threads can be started together. So only indexing, search, import or export can be started at once. I will try to find a solution if i find some time. |
20e1910
to
b2151a5
Compare
My idea was to have only one operation running at once, and so using only one common progres bar for all. Concurrency is nice, but the SW is currently not fully designed for this. Sometimes it will crash at the moment. |
Yeah, but changing that behavior (running indexing in the main thread) is
whole new story... Moreover, it means that user won't be able to start a search (the way he/she can do now) until indexing is not finished. Currently, for my dlt files indexing takes some minutes, which I would spend starring into monitor without being able to do my job.
P.S. I looked into indexing and honestly it has two stages: just indexing and indexing with filters, but since usually I do not have filters when I simply open a dlt file, the second index is identical to the first one. Why it is needed at all?.. But again, this is a separate question. As I said the only thing this PR does: it moves visual element (progress bar) from one place to another for more pleasant UI/UX
|
Ok i will test your implementation. Integration into a single progress bar can be also done later. |
@vifactor There is a height issue with the Toolbar, it is too high: |
interesting, I did not observe such thing on my machine. I'll try to understand why it is so, thanks for testing |
b2151a5
to
10574a0
Compare
10574a0
to
79d581d
Compare
Great, works now, will merge. |
From UX point of view, search progress bar dialog detached from main window is one of the most annoying things for me in the application. With this PR, I hide the input dropdown and replace it with a progress bar (+ cancel button) while search is in progress as demonstrated below:
#453