Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Password Reset/Update Functionality #58

Merged
merged 10 commits into from
Sep 23, 2024

Conversation

shishirbychapur
Copy link

UI Changes:
Screenshot 2024-09-22 210242
Screenshot 2024-09-22 210256

Email:
Screenshot 2024-09-22 210327

Flow:

  • User forgets their password, clicks on the reset password hyperlink, the dialog is opened, the user enters their email to which an 6 digit OTP is sent, and the user is prompted to enter the OTP to verify the reset attempt. [NOTE: the frontend/backend have yet to be linked]
  • User wishes to update their password when they are already logged in, they can now do so (added a new route in the backend which supports updating the password)

Copy link

@glemenneo glemenneo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from my other comments, there is good work here, especially the nodemailer and gmail smtp solution. I'm curious if gmail smtp has a limit or cost based on the emails sent?

backend/user-service/package.json Show resolved Hide resolved
backend/user-service/package.json Outdated Show resolved Hide resolved
backend/user-service/src/controllers/auth.controller.ts Outdated Show resolved Hide resolved
backend/user-service/src/controllers/auth.controller.ts Outdated Show resolved Hide resolved
backend/user-service/src/routes/auth.routes.ts Outdated Show resolved Hide resolved
backend/user-service/src/routes/user.routes.ts Outdated Show resolved Hide resolved
@shishirbychapur
Copy link
Author

Aside from my other comments, there is good work here, especially the nodemailer and gmail smtp solution. I'm curious if gmail smtp has a limit or cost based on the emails sent?

thanks. i do not recall reading about a limit and afaik it is free. also, considering that we wont really be using this feature a lot, i think it should be good enough.

@shishirbychapur shishirbychapur merged commit 1870a7e into main Sep 23, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants