Protect against missing non-existent snapshot

CSFrequency · May 7, 2019 · ccf3616 · ccf3616
1 parent eaecf9c
commit ccf3616
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/database/helpers/index.ts b/database/helpers/index.ts
@@ -7,6 +7,10 @@ export const snapshotToData = (
   snapshot: database.DataSnapshot,
   keyField?: string
 ) => {
+  if (!snapshot.exists) {
+    return null;
+  }
+
   const val = snapshot.val();
   if (isObject(val)) {
     return {

diff --git a/firestore/helpers/index.ts b/firestore/helpers/index.ts
@@ -4,7 +4,10 @@ export const snapshotToData = (
   snapshot: firestore.DocumentSnapshot,
   idField?: string
 ) => {
-  if (!snapshot.exists) return null;
+  if (!snapshot.exists) {
+    return null;
+  }
+
   return {
     ...snapshot.data(),
     ...(idField ? { [idField]: snapshot.id } : null),