Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TCH model of Triadic Closure & Homophily without Preferential Attachment #13

Merged
merged 2 commits into from
Aug 21, 2023

Conversation

mannbach
Copy link
Contributor

A simple growth model of Triadic Closure and Homophily, but without Preferential Attachment.

@mannbach mannbach added the enhancement New feature or request label Aug 21, 2023
return h_MM, h_mm

def infer_triadic_closure(self) -> float:
"""
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add a @todo or a message that implementation is not yet done.


def infer_homophily_values(self) -> Tuple[float, float]:
"""
Infers analytically the homophily values of the graph.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add a @todo or a message that implementation is not yet done.

Copy link
Contributor

@lisette-espin lisette-espin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mannbach please add a @todo comment on the inference of homophily and triadic closure indicating that these two methods still need to be implemented. Other than that, this is great, thanks!

@lisette-espin lisette-espin merged commit 2d80c70 into main Aug 21, 2023
@mannbach
Copy link
Contributor Author

Would it make sense to throw an error (e.g., NotImplementedError) or a warning? Or would it crash somewhere unexpectedly?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants