Skip to content

Commit

Permalink
Define ruff version in the github actions file instead
Browse files Browse the repository at this point in the history
Placing it in requirements.txt means the docker images try to install it
even though they don't need it.
  • Loading branch information
arichardson committed Apr 20, 2024
1 parent 88035b5 commit a398046
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 3 deletions.
7 changes: 5 additions & 2 deletions .github/workflows/python-app.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,9 @@ on:
pull_request:
branches: [ main ]

env:
RUFF_VERSION: 0.3.4

jobs:
build-baseline:
runs-on: ubuntu-latest
Expand All @@ -32,7 +35,7 @@ jobs:
# Use the system-provided python3 instead of actions/setup-python@v4
python3 --version
python3 -m pip install --upgrade pip
python3 -m pip install --upgrade pre-commit
python3 -m pip install --upgrade pre-commit ruff==${{ env.RUFF_VERSION }}
python3 -m pip install -r requirements.txt
- name: Lint with flake8
run: flake8
Expand All @@ -54,7 +57,7 @@ jobs:
- name: Install dependencies
run: |
python -m pip install --upgrade pip
pip install --upgrade pre-commit
pip install --upgrade pre-commit ruff==${{ env.RUFF_VERSION }}
if [ -f requirements.txt ]; then pip install -r requirements.txt; fi
- name: Lint with flake8
run: flake8
Expand Down
1 change: 0 additions & 1 deletion tests/requirements.txt
Original file line number Diff line number Diff line change
Expand Up @@ -5,4 +5,3 @@ argcomplete>=2.0.0
# Only needed for RISC-V FPGA boot -> not bundled
pyserial>=3.5
flake8
ruff==0.3.4

0 comments on commit a398046

Please sign in to comment.