Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default to purecap kernels for CheriBSD #389

Merged
merged 1 commit into from
Apr 22, 2024
Merged

Default to purecap kernels for CheriBSD #389

merged 1 commit into from
Apr 22, 2024

Conversation

brooksdavis
Copy link
Member

Switch the default kernel ABI to purecap

@brooksdavis brooksdavis requested a review from jrtc27 February 7, 2024 18:49
@brooksdavis brooksdavis mentioned this pull request Feb 7, 2024
Merged
arichardson
arichardson approved these changes Feb 7, 2024
View reviewed changes
Copy link
Member

@arichardson arichardson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests need updating otherwise LGTM

jrtc27
jrtc27 approved these changes Feb 7, 2024
View reviewed changes
Copy link
Member

@jrtc27 jrtc27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was initially concerned this would affect releng/23.11, but past Alex(?) was smart and explicitly passed --cheribsd/default-kernel-abi in Jenkinsfile so that's under CheriBSD's control already.

@brooksdavis
Copy link
Member Author

This is annoyingly more complicated that I'd hoped. Options like --cheribsd/build-fett-kernels and --cheribsd/build-bench-kernels don't have associated PURECAP kernels in the tree so it's not just a matter of flipping orders. It feels like those options want to ignore the default and I'm not sure what the right solution is.

@brooksdavis brooksdavis force-pushed the default-to-purecap branch 7 times, most recently from f85626d to 27442cf Compare April 22, 2024 15:18
@brooksdavis brooksdavis merged commit de423d1 into main Apr 22, 2024
5 checks passed
@brooksdavis brooksdavis deleted the default-to-purecap branch April 22, 2024 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arichardson arichardson arichardson approved these changes

@jrtc27 jrtc27 jrtc27 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@brooksdavis @jrtc27 @arichardson