Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test tidying #394

Merged
merged 1 commit into from
Apr 17, 2024
Merged

Test tidying #394

merged 1 commit into from
Apr 17, 2024

Conversation

brooksdavis
Copy link
Member

A bit of reformatting to simplify later diffs plus pacifying newer ruff versions.

@brooksdavis
Copy link
Member Author

@arichardson ruff seems to be broken. The first commit here fails when it passed before and the second is the fixes suggested by --fix with ruff from home-brew which also fails :(

@arichardson
Copy link
Member

@arichardson ruff seems to be broken. The first commit here fails when it passed before and the second is the fixes suggested by --fix with ruff from home-brew which also fails :(

I think the problem is that CI pulls the latest version of ruff - we should pin it to a fixed version.

@brooksdavis brooksdavis force-pushed the test-tidying branch 3 times, most recently from 63b1c2b to a8c5575 Compare April 17, 2024 20:32
Rewrap tests so each kernel is on it's own line.  This simplifies later
reordering.
@brooksdavis brooksdavis merged commit 9992f9b into main Apr 17, 2024
3 of 5 checks passed
@brooksdavis brooksdavis deleted the test-tidying branch April 17, 2024 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants