Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add build for B-lang-org/bsc-contrib repo as 'bluespec-libraries' target, also add 'bluespec' alias #404

Merged
merged 2 commits into from
Aug 12, 2024

Conversation

tmarkettos
Copy link
Contributor

'bluespec-libraries' builds and installs the B-lang-org/bsc-contrib repo into the local install.

'bluespec' is a dummy target which depends on 'bluespec-libraries' which depends on 'bluespec-compiler', so building 'bluespec' with dependencies builds both.

Upstream bluespec-compiler's makefile tends to rebuild all its BSV files even if nothing changed, so building 'bluespec-libraries' also causes the BSV inside bluespec-compiler to get rebuilt. Not sure if there's an easy solution for this.

'bluespec-libraries' builds and installs the B-lang-org/bsc-contrib repo
into the local install.

'bluespec' is a dummy target which depends on 'bluespec-libraries' which
depends on 'bluespec-compiler', so building 'bluespec' with dependencies
builds both.

Upstream bluespec-compiler's makefile tends to rebuild all its BSV files
even if nothing changed, so building 'bluespec-libraries' also causes the
BSV inside bluespec-compiler to get rebuilt.  Not sure if there's an easy
solution for this.
@tmarkettos tmarkettos requested a review from arichardson August 8, 2024 13:12
Copy link
Member

@arichardson arichardson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if it works for you

@tmarkettos tmarkettos merged commit ed00235 into main Aug 12, 2024
5 checks passed
@tmarkettos tmarkettos deleted the atm26-bsc-libs branch August 12, 2024 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants