Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gmake: bootstrap to fetch gnulib before configuring #405

Merged
merged 1 commit into from
Aug 21, 2024

Conversation

nwf
Copy link
Member

@nwf nwf commented Aug 19, 2024

Without this, the build dies with

cd /cheri/source/mainline/gmake && /cheri/source/mainline/gmake/autogen.sh
/cheri/source/mainline/gmake/autogen.sh: 1088: cannot open gnulib/gnulib-tool: No such file
Fatal error (in target gmake-aarch64): Command `/cheri/source/mainline/gmake/autogen.sh` failed with non-zero exit code 2. Working directory was /cheri/source/mainline/gmake

Copy link
Member

@arichardson arichardson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm I think this should probably be inside configure()? ideally setup() should not modify the source dir.

@nwf nwf force-pushed the 202408-gmake-bootstrap branch from b1887a5 to 455df59 Compare August 21, 2024 10:08
@nwf
Copy link
Member Author

nwf commented Aug 21, 2024

Even more ideally that'd work in the build dir, but it does not, so source dir modification in configure() it is.

@arichardson arichardson merged commit e8cf313 into CTSRD-CHERI:main Aug 21, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants