Fixing tests related to repo restructuring #24
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ok, everything passes now on windows and linux, but not macos. |
justbuchanan
force-pushed
the
restructure-justin
branch
3 times, most recently
from
bceffb8 to
65dc1be
Compare
fixes "libGL.so.1: cannot open shared object file"
justbuchanan
force-pushed
the
restructure-justin
branch
3 times, most recently
from
8615eb2 to
05d686f
Compare
justbuchanan
force-pushed
the
restructure-justin
branch
from
05d686f to
fe6a4fc
Compare
|
The tests are passing on linux and windows, but macos gives us: |
|
The MacOS runner has been a pain on this repo for some reason. You can just take it out of the matrix for now and I'll fix it later. Thanks |
|
Actually, I'll just merge this and disable MaxOS. Thanks for fixing the tests. |
|
All green now on the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is just a small addition to #23. I'm opening it to get some feedback from GitHub actions and see if test fixes are working.
@jmwright if this PR is helpful, feel free to just merge this into #23 and close it.
Notes:
src/cq_cli/cq_cli.pyrather than the old pathcq-cli.pyapt-get install libgl1-mesa-glxto tests.yml. This seems to have fixed things for linux, but we'll have to do something different for macOS and windows. Update: I was able to change this to only runapt-get installon linux