Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump nesbot/carbon from 2.67.0 to 2.68.1 #462

Closed
wants to merge 1 commit into from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jul 3, 2023

Bumps nesbot/carbon from 2.67.0 to 2.68.1.

Release notes

Sourced from nesbot/carbon's releases.

2.68.1

Complete commits list: briannesbitt/Carbon@2.68.0...2.68.1

Summary:

  • Fixed bug mutating the parameter of diffInWeekdays() and diffInWeekendDays()

2.68.0

Complete commits list: briannesbitt/Carbon@2.67.0...2.68.0

Summary:

Breaking chances (for edge-case usages): ⚠️ Now mixin methods will respect mutability: for instance if you previously returned $this->modify() or $this->setTimezone() from within a mixin method, previously you got a copy of the object, now you will get the same object, modified. If you want to maintain the previous behavior, you'll have to explicitly call $date = $this->copy(); at the beginning at mixin methods and then modify and return this copied instance. Alternatively you can use CarbonImmutable all way long so any modification (via macro, mixin or regular methods) will all create a new instance.

⚠️ Now CarbonPeriodImmutable emit CarbonImmutable objects on iteration, if you rely on receiving Carbon and doing mutation on it, you should call now explicitly first ->toMutable().

⚠️ Now diffInWeekdays and diffInWeekendDays returned before rounded-up values which was inconsistent with other diff methods all returning rounded-down value. If you were using those methods with start and end dates not having the same hour/minute/second and were willingly expecting rounded-up values, you should now add + ($start->isSameAs('H:i:s.u', $end) ? 0 : 1) to get the same result as before.

Commits
  • 4f991ed Fix mutation bug in diffInWeekdays() and diffInWeekendDays()
  • cfb8701 Fix code style
  • ae0ae7c Add test message for mutability expectation
  • 757dd02 Add more tests for mixin mutability
  • 2358710 Fix code style
  • 9f0bb30 Respect mixin mutability
  • 13cb760 Update sponsors
  • d4c55bc Merge pull request #2806 from axlon/fix-period-method-signatures
  • e5c5b8e Fix CarbonPeriod method signatures
  • 9b79266 Merge pull request #2805 from briannesbitt/test/compatibility-cleanup
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [nesbot/carbon](https://github.com/briannesbitt/Carbon) from 2.67.0 to 2.68.1.
- [Release notes](https://github.com/briannesbitt/Carbon/releases)
- [Commits](briannesbitt/Carbon@2.67.0...2.68.1)

---
updated-dependencies:
- dependency-name: nesbot/carbon
  dependency-type: indirect
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file php Pull requests that update Php code labels Jul 3, 2023
@dependabot dependabot bot requested a review from CaddyDz July 3, 2023 04:20
Copy link
Owner

@CaddyDz CaddyDz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Aug 17, 2023

Superseded by #528.

@dependabot dependabot bot closed this Aug 17, 2023
@dependabot dependabot bot deleted the dependabot/composer/nesbot/carbon-2.68.1 branch August 17, 2023 04:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file php Pull requests that update Php code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant