-
Notifications
You must be signed in to change notification settings - Fork 814
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prompts/popups use translation strings #2283
Open
Madis0
wants to merge
15
commits into
CaffeineMC:dev
Choose a base branch
from
Madis0:unhardcode-texts
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Madis0
commented
Jan 28, 2024
src/main/java/me/jellysquid/mods/sodium/client/gui/prompt/ScreenPrompt.java
Outdated
Show resolved
Hide resolved
Madis0
commented
Jan 28, 2024
"sodium.options.buttons.donate": "Buy us a coffee!", | ||
"sodium.prompt.donate.contents": "Hello!\n\nIt seems that you've been enjoying §x27eb92Sodium§r, the free and open-source optimization mod for Minecraft.\n\nMods like these are complex. They require §xff6e00thousands of hours§r of development, debugging, and tuning to create the experience that players have come to expect.\n\nIf you'd like to show your token of appreciation, and support the development of our mod in the process, then consider §xed49cebuying us a coffee§r.\n\nAnd thanks again for using our mod! We hope it helps you (and your computer.)", | ||
"sodium.prompt.donate.action": "Buy us a coffee", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Intentionally separate string from ln 59 because the prompt action can be different from the static button (#2008)
Madis0
changed the title
Change literals into translatables
Prompts/popups use translation strings
Jan 28, 2024
Octol1ttle
reviewed
Jan 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes several string literals use Sodium's or Minecraft's locale strings.
Affected:
I didn't change the RTSS and jar running stuff because I think these would not work the same way.
The changes have been tested and are working.