New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change how hollow cage-like blocks are culled #2920

Open

muzikbike wants to merge 2 commits into CaffeineMC:dev from muzikbike:patch-3

Contributor

muzikbike commented Dec 7, 2024

This changes spawners, trial spawners and vaults:

The cullface that spawners use is misconfigured, such that north and south occlusions cull the opposite face rather than the touching face, unlike the other two axes which behave as expected (https://bugs.mojang.com/browse/MC-266463).
Vaults do not cull their insides at all in vanilla (https://bugs.mojang.com/browse/MC-268242), so I've defined face culling for these as well to be consistent with spawners.

Putting these in a separate PR from optimizations as these do in fact change how vanilla looks in a survival environment.

muzikbike added 2 commits

December 7, 2024 15:25


          we be startin anotha PR

d9c2cde


          culling changes for "hollow" blocks

88edbdc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet