Code

Improve Fluid Shaping#2931

Code

Open

douira wants to merge 29 commits intoCaffeineMC:devCaffeineMC/sodium:devfrom douira:fix-waterlogging-slantsdouira/sodium:fix-waterlogging-slantsCopy head branch name to clipboard

+619-355

Commits

Commits on Dec 7, 2024

• fix same fluid type test

  douira

  committed
  3f8254d

• remove unnecessary direction parameter from fluidHeight method

  douira

  committed
  cee72df

• fix block occlusion cache java doc

  douira

  committed
  dd17ebd

• move accurate fluid culling to BlockOcclusionCache as well

  douira

  committed
  2b703ab

• consistent scratch pos usage

  douira

  committed
  8a86f75

• refactor block pos handling, use correct facing for occlusion shape isSideExposed

  douira

  committed
  eb1e0ad

• break out self occlusion into own method

  douira

  committed
  446df98

• fix fluid occlusion for non-full height blocks

  douira

  committed
  ea0655b

• change fluid behavior around opaque waterlogged blocks to not slant the fluids towards each other unless they're actually connected

  douira

  committed
  e9c8087

Commits on Dec 10, 2024

• fix fluid mesh continuity and refactor corner fluid height calculation,

  Show description for 17f2c3c
  douira

  committed
  17f2c3c

• refactor flags to make them less confusing, rename methods, remove redundant checks and methods, simplify methods where possible

  douira

  committed
  52088fb

• add flowing water flattening factor to approximate the previous look of thin flowing water end-pieces

  douira

  committed
  1159cf5

• improved neighbor check for up face occlusion

  douira

  committed
  2f17b31

• cleanup ordering and formatting

  douira

  committed
  bad5d51

• fix shaping of fluids around diagonal waterfalls,

  Show description for d59f674
  douira

  committed
  d59f674

• add inwards facing quads for fluid down faces,

  Show description for 1d9495f
  douira

  committed
  1d9495f

Commits on Dec 11, 2024

• remove unnecessary self visibility checks

  douira

  committed
  baba058

• improve top face hiding heuristic to also check for source blocks

  douira

  committed
  6972baf

• weight samples like reference implementation to prevent weird flow patterns

  douira

  committed
  a7c43f2

• add documentation for what the visibility concepts are, opportunistically reduce visibility as available

  douira

  committed
  bc0215d

• improve inwards facing bottom fluid face test, it was too frequent

  douira

  committed
  4c635e9

Commits on Dec 13, 2024

• avoid unnecessary coordinate fetch

  douira

  committed
  75edd07

Commits on Dec 15, 2024

• use same inwards water quad heuristic for down face as for side faces

  douira

  committed
  6232e94

• better cave water occlusion heuristic using floodfill

  douira

  committed
  20fcd63

• make cave water occlusion faster by using a stack instead of a queue for the search

  douira

  committed
  833e41f

• cleanup

  douira

  committed
  e2f8d63

Commits on Dec 18, 2024

• Fix bug with cave water heuristic

  douira

  committed
  4a5d88e

• add documentation

  douira

  committed
  6c4f940

Commits on Dec 22, 2024

• use overlay test for rendering flush inward upper fluid quads,

  Show description for 9c9b755
  douira

  committed
  9c9b755