Set type of email notification #947
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this no email is sent. This has become necessary after the following change from CakeDC#685 https://github.com/CakeDC/users/pull/685/files#diff-087e5d4ddeb9b25aa37f089c2ce923ee418537310623b29d393404528f1797a3R73-R80
|
By the way, I haven't checked whether there are other places to adjust. |
steinkel
reviewed
Apr 26, 2021
src/Shell/UsersShell.php
Outdated
| @@ -239,6 +239,7 @@ public function passwordEmail() | |||
| 'expiration' => Configure::read('Users.Token.expiration'), | |||
| 'checkActive' => false, | |||
| 'sendEmail' => true, | |||
| 'type' => 'passord', | |||
There was a problem hiding this comment.
:embarrassing: Fixed
|
Please could you describe the use case when email is not being sent? I'd like to cover it with a unit test. Thanks, |
I think we tried to send the reset password link through the CLI, thus the adjusted Shell class, but no mail was sent due to the recent change mentioned. |
|
Thank you, we'll try to reproduce the issue in a unit test and fix it, thanks! |
|
well, you fix it already ;) I mean merge it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this no email is sent.
This has become necessary after the following change from #685
https://github.com/CakeDC/users/pull/685/files#diff-087e5d4ddeb9b25aa37f089c2ce923ee418537310623b29d393404528f1797a3R73-R80