Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Replace jQuery scrollTo plugin with custom implementation #425

Merged
merged 1 commit into from
Aug 23, 2022
Merged

fix: Replace jQuery scrollTo plugin with custom implementation #425

merged 1 commit into from
Aug 23, 2022

Conversation

thinkh
Copy link
Member

@thinkh thinkh commented Aug 23, 2022 •
edited
Loading

Closes #424

Developer Checklist (Definition of Done)

Issue

  • All acceptance criteria from the issue are met
  • Tested in latest Chrome/Firefox

UI/UX/Vis

  • Requires UI/UX/Vis review
    • Reviewer(s) are notified (tag assignees)
    • Review has occurred (link to notes)
    • Feedback is included in this PR
    • Reviewer(s) approve of concept and design

Code

  • Branch is up-to-date with the branch to be merged with, i.e., develop
  • Code is cleaned up and formatted
  • Unit tests are written (frontend/backend if applicable)
  • Integration tests are written (if applicable)

PR

  • Descriptive title for this pull request is provided (will be used for release notes later)
  • Reviewer and assignees are defined
  • Add type label (e.g., bug, feature) to this pull request
  • Add release label (e.g., release: minor) to this PR following semver
  • The PR is connected to the corresponding issue (via Closes #...)
  • Summary of changes is written

Summary of changes

  • Replace jQuery scrollTo plugin with custom scroll implementation
  • Uses requestAnimationFrame to animate the scroll position

Screenshots

No actual change visible (except the fix). The behavior is like before.

ordino-fix-scrollto.webm

Thanks for creating this pull request 🤗

@thinkh thinkh added type: bug Something isn't working type: technical debt Describes or removes a technical debt release: minor PR merge results in a new minor version labels Aug 23, 2022
@thinkh thinkh self-assigned this Aug 23, 2022
dvvanessastoiber
dvvanessastoiber approved these changes Aug 23, 2022
View reviewed changes
Copy link
Contributor

@dvvanessastoiber dvvanessastoiber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works in my tests, thank you for the fix! 👍

@thinkh thinkh merged commit a483aef into develop Aug 23, 2022
@thinkh thinkh deleted the thinkh/remove-jquery-scrollto branch August 23, 2022 14:44
puehringer
puehringer reviewed Aug 23, 2022
View reviewed changes
.yo-rc.json
"d3": "d3/d3",
"scrollTo": "jquery.scrollto/jquery.scrollTo.js",
"jquery": "jquery/dist/jquery"
"d3": "d3/d3"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not used anymore in the new webpack config, so it can be safely removed 👍

@dvvanessastoiber dvvanessastoiber mentioned this pull request Sep 8, 2022
Merged
2 tasks
ghost pushed a commit that referenced this pull request Sep 8, 2022
@dvvanessastoiber @thinkh
@oltionchampari @dg-datavisyn @dvflorianengertsberger @datavisyn-bot @puehringer @dvtschachinger
Release 13.0.0 (#426)
edf8732 
* prepare next development version 12.0.1-SNAPSHOT

* Fix ref in replace views w/ `findOrAddObject()`

Fixes #402

See GitHub issue for in-depth analysis and testing results.

* Add missing dist files

* Use context to get current view name

Fixes #254

* Remove `nav.mainNavi` styles (#415)

I couldn't find any occurence or usage of the CSS class `mainNavi` in the TypeScript code of the phovea, Caleydo, or datavisyn organization, nor do know where this element would be. Hence, I would remove this code.

* Prepare github changes

* Remove circleci

* prepare next dev version

* Update fontawesome

* refactor: Improve Cypress setup and use Cypress commands.js (#354)

Co-authored-by: Florian Engertsberger <florian.engertsberger@datavisyn.io>
Co-authored-by: Holger Stitz <holger.stitz@datavisyn.io>

* feat: CLUE support for URL query parameter + refactor public session link (#419)

Co-authored-by: oltionchampari <oltion.champari@datavisyn.io>

* Add Visyn Scripts (#421)

* Prepare visyn_script changes

* Update package.json

* Remove prepack script

* Removed phovea_registry.js from package.json files

* Update package.json

* Update package.json

* add depth

* Update package.json

* Update package.json

* Update package.json

* Update package.json

* Update package.json

* Update package.json

* Update engine and prepare script

* Add react resolutions and overrides

* Remove react and react-dom from deps

* add dist folder

* Added resolutions like overrides

* Fix wrongly formatted visyn_scripts git ssh link

* Remove .git from git+ssh link to visyn_script

* Add yarn-3.2.2

* Remove yarn-3.2.2 again

* Add .yarnrc.yml

* Add yarn-3.2.2

* Switch to visyn_scripts clean

* Change d3 to d3v3

Co-authored-by: anita-steiner <>
Co-authored-by: Anita Steiner <anita.steiner@datavisyn.io>
Co-authored-by: Michael Puehringer <michael.puehringer@datavisyn.io>

* Add dist/ folder (#423)

* fix: Replace jQuery scrollTo plugin with custom implementation (#425)

Replace jquery scrollTo plugin with custom impl

* prepare release 13.0.0

Co-authored-by: Holger Stitz <holger.stitz@datavisyn.io>
Co-authored-by: Champari Oltion <51322092+oltionchampari@users.noreply.github.com>
Co-authored-by: Dominic Girardi <45822063+dg-datavisyn@users.noreply.github.com>
Co-authored-by: anita-steiner <>
Co-authored-by: Florian Engertsberger <florian.engertsberger@datavisyn.io>
Co-authored-by: oltionchampari <oltion.champari@datavisyn.io>
Co-authored-by: datavisyn-bot <32451285+datavisyn-bot@users.noreply.github.com>
Co-authored-by: Anita Steiner <anita.steiner@datavisyn.io>
Co-authored-by: Michael Puehringer <michael.puehringer@datavisyn.io>
Co-authored-by: Thomas Schachinger <79898881+dvtschachinger@users.noreply.github.com>
ghost pushed a commit that referenced this pull request Sep 30, 2022
@dvvanessastoiber @thinkh
@oltionchampari @dg-datavisyn @dvflorianengertsberger @datavisyn-bot @puehringer @dvtschachinger
Release 13.0.1 (#428)
f0022d6 
* prepare next development version 12.0.1-SNAPSHOT

* Fix ref in replace views w/ `findOrAddObject()`

Fixes #402

See GitHub issue for in-depth analysis and testing results.

* Add missing dist files

* Use context to get current view name

Fixes #254

* Remove `nav.mainNavi` styles (#415)

I couldn't find any occurence or usage of the CSS class `mainNavi` in the TypeScript code of the phovea, Caleydo, or datavisyn organization, nor do know where this element would be. Hence, I would remove this code.

* Prepare github changes

* Remove circleci

* prepare next dev version

* Update fontawesome

* refactor: Improve Cypress setup and use Cypress commands.js (#354)

Co-authored-by: Florian Engertsberger <florian.engertsberger@datavisyn.io>
Co-authored-by: Holger Stitz <holger.stitz@datavisyn.io>

* feat: CLUE support for URL query parameter + refactor public session link (#419)

Co-authored-by: oltionchampari <oltion.champari@datavisyn.io>

* Add Visyn Scripts (#421)

* Prepare visyn_script changes

* Update package.json

* Remove prepack script

* Removed phovea_registry.js from package.json files

* Update package.json

* Update package.json

* add depth

* Update package.json

* Update package.json

* Update package.json

* Update package.json

* Update package.json

* Update package.json

* Update engine and prepare script

* Add react resolutions and overrides

* Remove react and react-dom from deps

* add dist folder

* Added resolutions like overrides

* Fix wrongly formatted visyn_scripts git ssh link

* Remove .git from git+ssh link to visyn_script

* Add yarn-3.2.2

* Remove yarn-3.2.2 again

* Add .yarnrc.yml

* Add yarn-3.2.2

* Switch to visyn_scripts clean

* Change d3 to d3v3

Co-authored-by: anita-steiner <>
Co-authored-by: Anita Steiner <anita.steiner@datavisyn.io>
Co-authored-by: Michael Puehringer <michael.puehringer@datavisyn.io>

* Add dist/ folder (#423)

* fix: Replace jQuery scrollTo plugin with custom implementation (#425)

Replace jquery scrollTo plugin with custom impl

* prepare next dev version

* Improve typings for new session functions (#427)

* Improve typings for new session functions

datavisyn/ordino_eins#525

* Add `await` to `initSessionImpl`

* Add `await` to init session and push view

* Make `pushStartViewToSession` protected

Required to call this function from extended OrdinoApp

* prepare release 13.0.1

Co-authored-by: Holger Stitz <holger.stitz@datavisyn.io>
Co-authored-by: Champari Oltion <51322092+oltionchampari@users.noreply.github.com>
Co-authored-by: Dominic Girardi <45822063+dg-datavisyn@users.noreply.github.com>
Co-authored-by: anita-steiner <>
Co-authored-by: Florian Engertsberger <florian.engertsberger@datavisyn.io>
Co-authored-by: oltionchampari <oltion.champari@datavisyn.io>
Co-authored-by: datavisyn-bot <32451285+datavisyn-bot@users.noreply.github.com>
Co-authored-by: Anita Steiner <anita.steiner@datavisyn.io>
Co-authored-by: Michael Puehringer <michael.puehringer@datavisyn.io>
Co-authored-by: Thomas Schachinger <79898881+dvtschachinger@users.noreply.github.com>
@thinkh thinkh mentioned this pull request Jul 28, 2023
Merged
dvvanessastoiber added a commit that referenced this pull request Jul 28, 2023
@dvvanessastoiber
Release 14.0.0 (#433)
c61551d 
## What's Changed

### Features
* CLUE support for URL query parameter + refactor public session link by
@thinkh in #419
* Replace jQuery scrollTo plugin with custom implementation by @thinkh
in #425
* Improve typings for new session functions by @thinkh in
#427
* Allow tour card description to include html by @oltionchampari in
#432

### Bugfixes

* Fix wrong view name in replace action title by using `ViewWrapper`
context by @thinkh in #406
* Fix app crash when replacing views with object ref from
`graph.findOrAddObject()` by @thinkh in
#405
* Add vertical padding to tour cards and use full height teaser image by
@dvmichaelpeterseil in #430

### Chore

* Remove `nav.mainNavi` styles by @thinkh in
#415
* Improve Cypress setup and use Cypress commands.js by @dvvanessastoiber
in #354
* Add Visyn Scripts by @datavisyn-bot in
#421
* Add dist/ folder by @dvtschachinger in
#423
* Migration to visyn_core by @oltionchampari in
#429
* React 18 Migration by @dvmoritzschoefl in
#431

## New Contributors
* @datavisyn-bot made their first contribution in
#421
* @dvtschachinger made their first contribution in
#423
* @dvmichaelpeterseil made their first contribution in
#430
* @dvmoritzschoefl made their first contribution in
#431

**Full Changelog**:
v13.0.1...v14.0.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@puehringer puehringer puehringer left review comments

@dvvanessastoiber dvvanessastoiber dvvanessastoiber approved these changes

Assignees

@thinkh thinkh

Labels
release: minor PR merge results in a new minor version type: bug Something isn't working type: technical debt Describes or removes a technical debt
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thinkh @puehringer @dvvanessastoiber