Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add destructuring to more places #130

Merged
merged 10 commits into from
Jul 14, 2024

Conversation

BobVarioa
Copy link
Contributor

@BobVarioa BobVarioa commented Jul 12, 2024

Fixes #122

Adds destructuring to:

  • for..of
  • for..in
  • Assignment
  • Function Arguments

The only other supported destructuring location (?) is try..catch's error but that's currently unimplemented.

(also >30% test262 completion 🎉, at least for me locally)

Copy link
Owner

@CanadaHonk CanadaHonk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for the most part, thanks a lot! Just some nits/questions :)

compiler/codegen.js Outdated Show resolved Hide resolved
compiler/codegen.js Outdated Show resolved Hide resolved
compiler/codegen.js Show resolved Hide resolved
@CanadaHonk CanadaHonk merged commit 8de3f67 into CanadaHonk:main Jul 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support destructuring in places other than VariableDeclaration
2 participants