Cleaner dom tree

Canadian-Geospatial-Platform · Oct 2, 2023 · e423c1c · e423c1c
1 parent 260511f
commit e423c1c
Showing 1 changed file with 6 additions and 5 deletions.
diff --git a/src/chart/chart.tsx b/src/chart/chart.tsx
@@ -81,7 +81,7 @@ export function Chart(props: TypeChartChartProps<GeoChartType>): JSX.Element {
     };
   });
 
-  function renderChart() {
+  function renderChart(): JSX.Element {
     // Depending on the type of chart
     switch (options.geochart.chart) {
       case 'bar':
@@ -124,7 +124,7 @@ export function Chart(props: TypeChartChartProps<GeoChartType>): JSX.Element {
     }
   }
 
-  function renderXSlider() {
+  function renderXSlider(): JSX.Element {
     const { xSlider } = options.geochart;
     if (xSlider?.display) {
       return (
@@ -149,7 +149,7 @@ export function Chart(props: TypeChartChartProps<GeoChartType>): JSX.Element {
     return <div />;
   }
 
-  function renderYSlider() {
+  function renderYSlider(): JSX.Element {
     const { ySlider } = options.geochart;
     if (ySlider?.display) {
       return (
@@ -174,7 +174,7 @@ export function Chart(props: TypeChartChartProps<GeoChartType>): JSX.Element {
     return <div />;
   }
 
-  function renderChartContainer() {
+  function renderChartContainer(): JSX.Element {
     if (options && options.geochart && options.geochart.chart) {
       return (
         <div className={styles.chartContainer}>
@@ -185,7 +185,8 @@ export function Chart(props: TypeChartChartProps<GeoChartType>): JSX.Element {
         </div>
       );
     }
+    return <div></div>;
   }
 
-  return <div>{renderChartContainer()}</div>;
+  return renderChartContainer();
 }