Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove workaround for cibuildwheel problem #1796

Merged
merged 1 commit into from
Oct 11, 2024

Conversation

bryanwweber
Copy link
Member

Changes proposed in this pull request

Checklist

  • The pull request includes a clear description of this code change
  • Commit messages have short titles and reference relevant issues
  • Build passes (scons build & scons test) and unit tests address code coverage
  • Style & formatting of contributed code follows contributing guidelines
  • The pull request is ready for review

Copy link

codecov bot commented Oct 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.23%. Comparing base (e30f48a) to head (f7d6d15).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1796      +/-   ##
==========================================
- Coverage   73.24%   73.23%   -0.01%     
==========================================
  Files         381      381              
  Lines       54375    54375              
  Branches     9254     9254              
==========================================
- Hits        39826    39823       -3     
- Misses      11578    11580       +2     
- Partials     2971     2972       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bryanwweber bryanwweber marked this pull request as ready for review October 8, 2024 15:12
@speth speth merged commit 4ba45d3 into Cantera:main Oct 11, 2024
50 of 51 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants