Skip to content

Commit

Permalink
chore: remove pages router version
Browse files Browse the repository at this point in the history
  • Loading branch information
georgeherby committed Feb 25, 2024
1 parent 84f4eb4 commit 385354b
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 7 deletions.
2 changes: 0 additions & 2 deletions ui/src/app/projects/[projectId]/traces/page.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,6 @@ export default async function Traces({ params, searchParams }:
startDate?: string,
endDate?: string,
feedbackFilters?: string

//TODO - inLast is not used in the original code
inLast?: string
}
}) {
Expand Down
8 changes: 3 additions & 5 deletions ui/src/models/responses/trace-detail-response.ts
Original file line number Diff line number Diff line change
Expand Up @@ -20,10 +20,8 @@ export interface TraceTreeNode {
totalTokens?: number;
depth?: number;
feedback?: { [key: string]: any }; //TODO Make this a proper type

execution_order?: number; //TODO This is only used for old format (pre version....)

trace_id?: string; //TODO This is only used for new format (post version....)
dotted_order?: string; //TODO This is only used for new format (post version....)
execution_order?: number; // (<= langsmith-sdk v0.0.90)
trace_id?: string; // (>= langsmith-sdk v0.0.90)
dotted_order?: string; // (>= langsmith-sdk v0.0.90)

}

0 comments on commit 385354b

Please sign in to comment.