fix: issues with validting "user provided value" beig used in database

CapgeminiInventUK · Sep 23, 2024 · 7ab36e1 · 7ab36e1
1 parent 195c7ac
commit 7ab36e1
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 9 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/packages/ingest/src/repositories/mongodb-repository.ts b/packages/ingest/src/repositories/mongodb-repository.ts
@@ -18,14 +18,18 @@ export class MongodbRepository {
     });
   }
 
-  async insertTrace(langscoutData: TraceData): Promise<void> {
+  async insertTrace(data: TraceData): Promise<void> {
     const collection = this.db.collection(this.collectionName);
-    await collection.insertOne(langscoutData);
+    await collection.insertOne(data);
   }
 
-  async updateTrace(langscoutId: string, updateData: TraceData): Promise<UpdateResult> {
+  async updateTrace(id: string, updateData: TraceData): Promise<UpdateResult> {
+    if (!/^[0-9a-f]{8}-[0-9a-f]{4}-4[0-9a-f]{3}-[89ab][0-9a-f]{3}-[0-9a-f]{12}$/i.test(id)) {
+      throw new Error(`Invalid UUID v4 format (${id}) for updateTrace`);
+    }
+
     const collection = this.db.collection(this.collectionName);
-    return collection.updateOne({ run_id: { $eq: langscoutId } }, { $set: { ...updateData } });
+    return collection.updateOne({ run_id: { $eq: id } }, { $set: { ...updateData } });
   }
 
   async insertFeedbackOnTraceByRunId(feedback: CreateFeedback) {

diff --git a/packages/ingest/src/services/langchain-to-langscout-service.ts b/packages/ingest/src/services/langchain-to-langscout-service.ts
@@ -34,9 +34,12 @@ export class LangchainToLangscoutService {
     if (!langchainData.id) {
       throw new Error('id is required in data');
     }
+
+
+
     langchainData.run_id = langchainData.id;
     delete langchainData.id;
-    
+
     this.convertToDates(langchainData);
 
     const updateResult = await this.repository.updateTrace(traceId, langchainData);