Clean up test.run code. #146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The file lists returned by the finder are already iterable, so there's no need to create a new list from them. If there were just wrapping them in `list()` is another possiblity. Also update the comments so they match the code better.
|
I should have time to take a look at it later this week. Ping me again if you haven't heard anything by Thursday (June 20). |
|
Ok. Thanks for the update! |
|
Love the change in comments, definitely a good pr. Thanks ! |
|
\o/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is some cleanup of the code around the parallel iterators in Test.run I did while investigating #145.
The file lists returned by the finder are already iterable,
so there's no need to create a new list from them. If there
were just wrapping them in
list()is another possiblity.Also update the comments so they match the code better.