Feature/55 data domain registration login #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
.../main/java/app/cashadvisor/authorization/data/model/response/ResetPasswordByEmailResponse.kt
Outdated
Show resolved
Hide resolved
avanisimov
reviewed
Jan 28, 2024
app/src/main/java/app/cashadvisor/authorization/data/network/AuthApiService.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/app/cashadvisor/authorization/data/repositoryImpl/AuthRepositoryImpl.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/app/cashadvisor/common/data/network/ErrorInterceptor.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/app/cashadvisor/common/domain/ExceptionToErrorMapperBase.kt
Outdated
Show resolved
Hide resolved
.../main/java/app/cashadvisor/authorization/data/model/response/ResetPasswordByEmailResponse.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/app/cashadvisor/common/data/network/ErrorCodeMapper.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/app/cashadvisor/common/data/network/ErrorInterceptor.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/app/cashadvisor/common/data/network/ErrorInterceptor.kt
Outdated
Show resolved
Hide resolved
1) Split ds, repo and interactor to login and register 2) Added state for confirmation code token in repos 3) Refactored hilt modules 3) Went through some refactoring (naming etc)
# Conflicts: # app/build.gradle.kts # app/src/main/AndroidManifest.xml # app/src/main/java/app/cashadvisor/authorization/di/AuthorizationDataModule.kt # app/src/main/java/app/cashadvisor/authorization/domain/impl/AccountInformationInteractorImpl.kt # app/src/main/java/app/cashadvisor/authorization/presentation/ui/StartFragment.kt # app/src/main/java/app/cashadvisor/main/presentation/ui/MainActivity.kt # app/src/main/res/layout/fragment_start.xml # app/src/main/res/navigation/nav_graph.xml # settings.gradle.kts
1) Changed names for mor accurate 2) Changed response and dto fields according backend changes
# Conflicts: # app/src/main/java/app/cashadvisor/main/presentation/ui/MainActivity.kt
JudjinGM
requested review from
Barsec13,
n-shvedov27,
RinatGiniyatullin and
alexxk2
JudjinGM
requested review from
MajoritySky2496,
Usynin1994,
tsurkanaleksey,
a team and
artwist-polyakov
# Conflicts: # app/src/main/java/app/cashadvisor/authorization/presentation/viewmodel/StartViewModel.kt
|
Проверить работоспособность можно в debug сборке, перейти в uiKit и выбрать Test fragment. |
app/src/main/java/app/cashadvisor/authorization/data/models/response/ConfirmRegisterResponse.kt
Show resolved
Hide resolved
app/src/main/java/app/cashadvisor/authorization/data/impl/RegisterRemoteDataSourceImpl.kt
Show resolved
Hide resolved
MajoritySky2496
approved these changes
Mar 1, 2024
Barsec13
approved these changes
Mar 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented data layer for login only, to know is it okay