new branch with list and intermidiate solution of linked list #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oleksandrsu
reviewed
Jun 6, 2022
Comment on lines
+21
to
+22
| addNode.left = null; | ||
| addNode.right = null; |
There was a problem hiding this comment.
It's redundant initialisation
Suggested change
| addNode.left = null; | |
| addNode.right = null; |
Comment on lines
+28
to
+29
| if (value > thisNode.value) thisNode = thisNode.right; | ||
| if (value <= thisNode.value) thisNode = thisNode.left; |
There was a problem hiding this comment.
Use curly brackets for one-line if, please
Suggested change
| if (value > thisNode.value) thisNode = thisNode.right; | |
| if (value <= thisNode.value) thisNode = thisNode.left; | |
| if (value > thisNode.value) { | |
| thisNode = thisNode.right; | |
| } | |
| if (value <= thisNode.value) { | |
| thisNode = thisNode.left; | |
| } |
| } | ||
| if (value > thisNode.value) { | ||
| thisNode.right = addNode; | ||
| } else thisNode.left = addNode; |
| root = addNode; | ||
| } else { | ||
| Node thisNode = root; | ||
| while (thisNode.right != null && thisNode.left != null) { |
There was a problem hiding this comment.
Wrong loop logic, I guess it's better to check whether thisNode != null
| return false; | ||
| Node removeNode = root; | ||
| while (removeNode.value != value) { | ||
| if (value > removeNode.value) removeNode = removeNode.right; |
| } | ||
|
|
||
| // Should remove specified value from tree and return true | ||
| // If value does not exist in this tree - return false | ||
| public boolean remove(int value) { | ||
| // TODO implement me | ||
| return false; | ||
| Node removeNode = root; | ||
| while (removeNode.value != value) { |
There was a problem hiding this comment.
what if removeNode == nul ??
Please, recheck loop condition
| if (value > removeNode.value) removeNode = removeNode.right; | ||
| else removeNode = removeNode.left; | ||
| } | ||
| if (removeNode.value != value) return false; |
There was a problem hiding this comment.
You can set code formatting in IntelijiIdea as google code style.
And then you can format code in right way
https://stackoverflow.com/questions/42979700/how-to-configure-google-java-code-formatter-in-intellij-idea-17
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.