Skip to content

Commit

Permalink
Ensure we delete VulkanBindImpl::mqToVulkanUpdate
Browse files Browse the repository at this point in the history
  • Loading branch information
Valakor committed Jan 10, 2024
1 parent 53897b4 commit b0bf7c5
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion lib/Remotery.c
Original file line number Diff line number Diff line change
Expand Up @@ -10463,6 +10463,7 @@ RMT_API rmtError _rmt_BindVulkan(void* instance, void* physical_device, void* de
assert(get_instance_proc_addr != NULL);

// Allocate the bind container
// TODO(valakor): If anything after this fails we'll leak this bind instance
rmtTryMalloc(VulkanBindImpl, bind);

// Set default state
Expand Down Expand Up @@ -10554,7 +10555,9 @@ RMT_API void _rmt_UnbindVulkan(rmtVulkanBind* bind)
mtxUnlock(&g_Remotery->vulkanBindsMutex);
}

// TODO: Clean up resources
// Clean up bind resources

rmtDelete(rmtMessageQueue, vulkan_bind->mqToVulkanUpdate);

if (vulkan_bind->gpuQuerySemaphore != NULL)
{
Expand Down

0 comments on commit b0bf7c5

Please sign in to comment.