Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ENG-4647] search api docs #813

Merged
merged 24 commits into from
Nov 9, 2023
Merged

[ENG-4647] search api docs #813

merged 24 commits into from
Nov 9, 2023

Conversation

aaxelb
Copy link
Contributor

@aaxelb aaxelb commented Nov 7, 2023 •
edited
Loading

paths:

  • /trove/docs/openapi.json
  • /trove/docs/openapi.html
  • /vocab/2023/trove/...

@coveralls
Copy link

coveralls commented Nov 7, 2023 •
edited
Loading

Coverage Status

coverage: 89.42% (-0.3%) from 89.746%
when pulling 65ba47e on feature/search-api-docs
into e4bf364 on develop.

mfraezz
mfraezz approved these changes Nov 8, 2023
View reviewed changes
Copy link
Member

@mfraezz mfraezz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discussed some dead links and TODO's to resolve when pair reviewing, but otherwise LGTM :octocat:

@aaxelb aaxelb changed the title [wip] search api docs [ENG-4647] search api docs Nov 9, 2023
@aaxelb aaxelb marked this pull request as ready for review November 9, 2023 16:36
@aaxelb aaxelb merged commit f99b3ae into develop Nov 9, 2023
3 of 6 checks passed
@aaxelb aaxelb deleted the feature/search-api-docs branch November 9, 2023 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mfraezz mfraezz mfraezz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aaxelb @coveralls @mfraezz