Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ENG-5494] simplest simple json #818

Merged
merged 1 commit into from
May 21, 2024
Merged

[ENG-5494] simplest simple json #818

merged 1 commit into from
May 21, 2024

Conversation

aaxelb
Copy link
Contributor

@aaxelb aaxelb commented May 20, 2024 •
edited by jira bot
Loading

  • add simple_json renderer for search api responses
    • includes the osfmap metadata record for each search result, total result count, and pagination links
    • omits everything else
  • use simple_json renderer for requests with query param acceptMediatype=application/json or header Accept: application/json

ENG-5494

@aaxelb aaxelb changed the title simplest simple json [ENG-5494] simplest simple json May 20, 2024
@aaxelb aaxelb force-pushed the feature/searchapi-simple-json--simple branch from 98e51d2 to 1a221cf Compare May 20, 2024 14:38
@coveralls
Copy link

coveralls commented May 20, 2024 •
edited
Loading

Coverage Status

coverage: 89.588% (-0.2%) from 89.741%
when pulling 5be7f2d on aaxelb:feature/searchapi-simple-json--simple
into fb8de52 on CenterForOpenScience:develop.

@aaxelb aaxelb marked this pull request as ready for review May 20, 2024 15:49
@aaxelb aaxelb force-pushed the feature/searchapi-simple-json--simple branch from 1a221cf to 5be7f2d Compare May 20, 2024 19:05
brianjgeiger
brianjgeiger approved these changes May 20, 2024
View reviewed changes
Copy link

@brianjgeiger brianjgeiger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, near as I can tell. 🐧

@aaxelb aaxelb merged commit df03378 into CenterForOpenScience:develop May 21, 2024
2 of 3 checks passed
@aaxelb aaxelb deleted the feature/searchapi-simple-json--simple branch May 21, 2024 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brianjgeiger brianjgeiger brianjgeiger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aaxelb @coveralls @brianjgeiger