Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENG-5493][ENG-5412] more helpful trove responses #820

Merged

Conversation

aaxelb
Copy link
Contributor

@aaxelb aaxelb commented May 23, 2024

ENG-5493

  • fill in trove/exceptions.py with situation-specific exception classes
  • use those specific exceptions thruout trove code
  • give an appropriate response when those specific exceptions happen while handling a request (currently always in jsonapi)
  • reduce dead links and other errors when browsing the search api
    • allow resolving static vocab terms (including "new" static vocabs skos, foaf, dc, dctype, dcam)
    • display datatypes for literals
  • add better search-api tests (with actual search indexes running)
  • fix broken next links with field-specific search (ENG-5412)
  • code cleanup
    • add trove.trovesearch with modules previously at trove.trovesearch_gathering, share.search.search_params, and share.search.search_response
    • render derived indexcard metadata as rdf literal (except html rendering) -- avoid errors from non-standard "quoted triple" or "quoted graph"
    • remove trove.render.osfmap_jsonld (subsumed by trove.derive.osfmap_json)
    • remove ingest_rdf_vocabs management command (unnecessary with "static vocab" update)
    • rename ...VOCAB to ...THESAURUS (not just a set of terms, but a whole rdf graph describing those terms)
    • remove trove.util.iri_labeler (completely replaced by primitive_rdf.IriShorthand
    • consolidate mediatypes as constants in trove.vocab.mediatypes
    • move all "static vocabs" into trove.vocab.static_vocab
    • add functools.cache to things that need be computed only once

@coveralls
Copy link

coveralls commented May 23, 2024

Coverage Status

coverage: 89.878% (+0.3%) from 89.605%
when pulling 5c61521 on aaxelb:fix/more-helpful-trove-responses
into 09c109f on CenterForOpenScience:develop.

@aaxelb aaxelb force-pushed the fix/more-helpful-trove-responses branch from f8729f6 to 0f63c47 Compare May 31, 2024 18:56
@aaxelb aaxelb changed the title (wip) more helpful trove responses [ENG-5493] more helpful trove responses May 31, 2024
@aaxelb aaxelb force-pushed the fix/more-helpful-trove-responses branch from 0f63c47 to aff34c5 Compare May 31, 2024 19:02
@aaxelb aaxelb changed the title [ENG-5493] more helpful trove responses [ENG-5493][ENG-5412] more helpful trove responses May 31, 2024
@aaxelb aaxelb marked this pull request as ready for review May 31, 2024 19:19
@aaxelb aaxelb merged commit 1810560 into CenterForOpenScience:develop May 31, 2024
3 checks passed
@aaxelb aaxelb deleted the fix/more-helpful-trove-responses branch May 31, 2024 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants