Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENG-6052] | Fixes to share for M chips discovered during local setup #821

Merged
merged 2 commits into from
Jul 31, 2024

Conversation

sh-andriy
Copy link
Contributor

No description provided.

@sh-andriy sh-andriy changed the title Fixes to share for M chips discovered during local setup [ENG-6052] | Fixes to share for M chips discovered during local setup Jul 29, 2024
@sh-andriy
Copy link
Contributor Author

Were encountering errors when running this command docker-compose up -d elastic8, such as network problems (share_network helped), still had other issues and after specifying platform it removed incompatible platforms warnings (arm with amd) and set elastic8 up without troubles.

When was testing the share project in osf (here http://localhost:5000/search) could not see any of my projects and encountered errors this fix helped me to solve them:
in docker-compose.yml:

in elastic8 service under environment category removed this line:
- cluster.initial_master_nodes=singlenode
add this line instead:
- discovery.type=single-node

Copy link
Member

@mfraezz mfraezz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Networking changes should be fine, and the change from cluster.initial_master_node to discovery.type makes sense -- if we're only running a one-node cluster, it should elect itself whenever it spins up.

I personally ran into an issue spinning up rabbitmq:management when it attempted to enable the stream_sac_coordinator_unblock_group feature flag, a recent addition in version 3.13. I found that specifying the 3.12-management-alpine tag instead allowed it to run. This may be a hardware issue, as I found reports of other M-series apple chips encountering the same or similar issues.

Overall, LGTM, but I'll leave it for @aaxelb to confirm and merge. :octocat:

Copy link
Contributor

@aaxelb aaxelb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, thanks! (and test failure unrelated)

@aaxelb aaxelb merged commit f93a70b into CenterForOpenScience:develop Jul 31, 2024
0 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants