Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENG-5859] Preprints affiliations detail page #2277

Conversation

Johnetordoff
Copy link

@Johnetordoff Johnetordoff commented Aug 5, 2024

Purpose

Add Preprints affiliations to detail page

Summary of Changes

  • added component for Preprint detail page that displays affiliation
  • added styles.scss to control styles.

Screenshot(s)

Screenshot 2024-08-06 at 3 02 24 PM

Mobile

Screenshot 2024-08-08 at 5 55 29 AM

Side Effects

QA Notes

Ticket

https://openscience.atlassian.net/browse/ENG-5859

@coveralls
Copy link

coveralls commented Aug 5, 2024

Pull Request Test Coverage Report for Build 10269019853

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 4 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.04%) to 63.016%

Files with Coverage Reduction New Missed Lines %
app/models/preprint.ts 4 0.0%
Totals Coverage Status
Change from base Build 9978336174: -0.04%
Covered Lines: 6207
Relevant Lines: 9533

💛 - Coveralls

John Tordoff added 2 commits August 6, 2024 08:04
@Johnetordoff Johnetordoff changed the title [WIP][ENG-5855] Preprints affiliations detail page [WIP][EBG-5859] Preprints affiliations detail page Aug 6, 2024
@Johnetordoff Johnetordoff force-pushed the feature/preprints-affiliations-detail-page branch 2 times, most recently from 543f34d to f2e29e7 Compare August 6, 2024 14:57
@Johnetordoff Johnetordoff force-pushed the feature/preprints-affiliations-detail-page branch from f2e29e7 to 9eb9ae2 Compare August 6, 2024 15:02
@Johnetordoff Johnetordoff changed the base branch from develop to feature/preprints-affiliations August 6, 2024 15:15
Copy link
Contributor

@bp-cos bp-cos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few updates to help with more explicit css.

@Johnetordoff Johnetordoff force-pushed the feature/preprints-affiliations-detail-page branch 2 times, most recently from b9b13b9 to cf3c111 Compare August 6, 2024 16:41
@Johnetordoff Johnetordoff force-pushed the feature/preprints-affiliations-detail-page branch from cf3c111 to defa0a1 Compare August 6, 2024 16:49
@Johnetordoff Johnetordoff changed the title [WIP][EBG-5859] Preprints affiliations detail page [WIP][ENG-5859] Preprints affiliations detail page Aug 6, 2024
@Johnetordoff Johnetordoff changed the title [WIP][ENG-5859] Preprints affiliations detail page [ENG-5859] Preprints affiliations detail page Aug 7, 2024
Copy link
Contributor

@bp-cos bp-cos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add the mobile view logic, accessibility and tests.

The -components/preprint-institutions/institution-manager is a good file to see the new "testing strategy"

The details/styles.scss is good reference for mobile.

@bp-cos bp-cos merged commit b197b10 into CenterForOpenScience:feature/preprints-affiliations Aug 9, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants