-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENG-5859] Preprints affiliations detail page #2277
[ENG-5859] Preprints affiliations detail page #2277
Conversation
Pull Request Test Coverage Report for Build 10269019853Details
💛 - Coveralls |
…enterForOpenScience/ember-osf-web into feature/preprints-affiliations-detail-page * 'feature/preprints-affiliations' of https://github.com/CenterForOpenScience/ember-osf-web: Added a trait Updates to the component and initial tests
543f34d
to
f2e29e7
Compare
f2e29e7
to
9eb9ae2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few updates to help with more explicit css.
app/preprints/-components/preprint-affiliated-institutions/styles.scss
Outdated
Show resolved
Hide resolved
app/preprints/-components/preprint-affiliated-institutions/template.hbs
Outdated
Show resolved
Hide resolved
app/preprints/-components/preprint-affiliated-institutions/template.hbs
Outdated
Show resolved
Hide resolved
b9b13b9
to
cf3c111
Compare
cf3c111
to
defa0a1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's add the mobile view logic, accessibility and tests.
The -components/preprint-institutions/institution-manager is a good file to see the new "testing strategy"
The details/styles.scss is good reference for mobile.
b197b10
into
CenterForOpenScience:feature/preprints-affiliations
Purpose
Add Preprints affiliations to detail page
Summary of Changes
Screenshot(s)
Mobile
Side Effects
QA Notes
Ticket
https://openscience.atlassian.net/browse/ENG-5859