Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENG-5855] Updates to the component and initial tests #2278

Conversation

bp-cos
Copy link
Contributor

@bp-cos bp-cos commented Aug 5, 2024

Purpose

Add model, mirage and test updates

Summary of Changes

Add model, mirage and test updates

Screenshot(s)

N/A

Side Effects

This is WIP and to help JonE

QA Notes

@bp-cos bp-cos requested a review from futa-ikeda August 5, 2024 19:56
Copy link
Contributor

@futa-ikeda futa-ikeda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor stuff that can be addressed later.

import Component from '@ember/component';

import { layout } from 'ember-osf-web/decorators/component';
import { InstitutionsManager } from 'osf-components/components/editable-field/institutions-manager/component';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will want to update this import later

@@ -0,0 +1,16 @@
import Component from '@ember/component';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will want to use glimmer component later

@bp-cos bp-cos merged commit 02d061c into CenterForOpenScience:feature/preprints-affiliations Aug 5, 2024
9 checks passed
@bp-cos bp-cos deleted the feature/eng-5855 branch August 5, 2024 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants