Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENG-5994] Fix Preprint Resubmission Workflow to Ensure Proper Moderation Handling #2279

Conversation

uditijmehta
Copy link
Contributor

  • Ticket: [https://openscience.atlassian.net/browse/ENG-5994]
  • Feature flag: n/a

Purpose

Fix Preprint Resubmission Workflow to Ensure Proper Moderation Handling

Summary of Changes

  • Added a hasMany relationship to review-action with the inverse set to target.
  • Changed the belongsTo relationship from registration to abstract-node with the inverse set to reviewActions.
  • Removed the conditional check for isEditFlow to ensure the review action is correctly triggered during both initial submission and edits.

@uditijmehta uditijmehta requested a review from adlius August 7, 2024 19:31
@coveralls
Copy link

coveralls commented Aug 7, 2024

Pull Request Test Coverage Report for Build 10303122417

Details

  • 0 of 6 (0.0%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.009%) to 63.06%

Changes Missing Coverage Covered Lines Changed/Added Lines %
app/preprints/-components/submit/preprint-state-machine/component.ts 0 6 0.0%
Files with Coverage Reduction New Missed Lines %
app/preprints/-components/submit/preprint-state-machine/component.ts 1 0.0%
Totals Coverage Status
Change from base Build 9978336174: 0.009%
Covered Lines: 6187
Relevant Lines: 9496

💛 - Coveralls

Copy link
Contributor

@adlius adlius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small nit.

@@ -15,6 +15,9 @@ export default class AbstractNodeModel extends BaseFileItem {

@attr('array') currentUserPermissions!: Permission[];

@hasMany('review-action', { inverse: 'target' })
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that we add this relationship on the parent model, should we delete it from the child classes?

@uditijmehta uditijmehta merged commit f53fbe2 into CenterForOpenScience:develop Aug 8, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants