[ENG-6070] Updated logic for the preprint institution component and more tests #2280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
futa-ikeda
requested changes
Aug 8, 2024
app/preprints/-components/preprint-institutions/institution-select-list/template.hbs
Outdated
Show resolved
Hide resolved
futa-ikeda
approved these changes
Aug 8, 2024
It's not in my hands. |
futa-ikeda
requested changes
Aug 9, 2024
app/preprints/-components/preprint-institutions/institution-select-list/component.ts
Show resolved
Hide resolved
app/preprints/-components/preprint-institutions/institution-select-list/template.hbs
Outdated
Show resolved
Hide resolved
futa-ikeda
approved these changes
Aug 9, 2024
bp-cos
merged commit 81f7846
into
CenterForOpenScience:feature/preprints-affiliations
7 of 9 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Use TDD principles to update the logic while testing
Summary of Changes
Added new logic to find the union between user institutions and preprint affiliated institutions while writing new tests.
Screenshot(s)
Side Effects
Likely a better way to find the union.
QA Notes